Skip to content

Commit

Permalink
Fix perma diff problem during TF import (GoogleCloudPlatform#7348)
Browse files Browse the repository at this point in the history
  • Loading branch information
hao-nan-li authored and mdtro committed Mar 2, 2023
1 parent 6a9ca89 commit 656eaec
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
2 changes: 1 addition & 1 deletion mmv1/products/cloudidentity/terraform.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ overrides: !ruby/object:Overrides::ResourceOverrides
custom_code: !ruby/object:Provider::Terraform::CustomCode
pre_create: templates/terraform/pre_create/hide_dynamic_label.erb
post_create: templates/terraform/post_create/unhide_dynamic_label.erb
custom_import: templates/terraform/custom_import/set_id_name_with_slashes.go.erb
custom_import: templates/terraform/custom_import/cloud_identity_group_import.go.erb
GroupMembership: !ruby/object:Overrides::Terraform::ResourceOverride
read_error_transform: "transformCloudIdentityGroupMembershipReadError"
docs: !ruby/object:Provider::Terraform::Docs
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
config := meta.(*Config)

// current import_formats can't import fields with forward slashes in their value
if err := parseImportId([]string{"(?P<name>.+)"}, d, config); err != nil {
return nil, err
}

name := d.Get("name").(string)

if d.Get("initial_group_config") == nil {
d.Set("initial_group_config", "EMPTY")
}

if err := d.Set("name", name); err != nil {
return nil, fmt.Errorf("Error setting name: %s", err)
}
d.SetId(name)
return []*schema.ResourceData{d}, nil

0 comments on commit 656eaec

Please sign in to comment.