Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional region field #7770

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Apr 19, 2023

fixes hashicorp/terraform-provider-google#12944

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vertexai: added `region` field to `google_vertex_ai_endpoint`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 15 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 15 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2640
Passed tests 2355
Skipped tests: 277
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceAlloydbLocations_basic|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange[Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@trodge trodge requested a review from hao-nan-li April 19, 2023 19:24
Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahvar
Copy link

mahvar commented Apr 19, 2023

Are there any examples how to use this field? There is also the location field. Shall we set both?

@trodge
Copy link
Contributor Author

trodge commented Apr 21, 2023

Are there any examples how to use this field? There is also the location field. Shall we set both?

Yes, both should be set unless region is set in the provider.

ravisiddhu pushed a commit to ravisiddhu/magic-modules that referenced this pull request Apr 25, 2023
* Add optional region field

* Add field to example and test
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
* Add optional region field

* Add field to example and test
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
* Add optional region field

* Add field to example and test
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 27, 2023
* Add optional region field

* Add field to example and test
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
* Add optional region field

* Add field to example and test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_vertex_ai_endpoint: Cannot determine region
4 participants