Add optional region field (GoogleCloudPlatform#7770)

* Add optional region field * Add field to example and test
ravisiddhu · Apr 25, 2023 · 02d3e7e · 02d3e7e
1 parent 51a6738
commit 02d3e7e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/mmv1/products/vertexai/Endpoint.yaml b/mmv1/products/vertexai/Endpoint.yaml
@@ -64,6 +64,11 @@ parameters:
     url_param_only: true
     required: true
     immutable: true
+  - !ruby/object:Api::Type::String
+    name: region
+    description: The region for the resource
+    url_param_only: true
+    immutable: true
 properties:
   - !ruby/object:Api::Type::String
     name: name

diff --git a/mmv1/templates/terraform/examples/vertex_ai_endpoint_network.tf.erb b/mmv1/templates/terraform/examples/vertex_ai_endpoint_network.tf.erb
@@ -3,6 +3,7 @@ resource "google_vertex_ai_endpoint" "<%= ctx[:primary_resource_id] %>" {
   display_name = "sample-endpoint"
   description  = "A sample vertex endpoint"
   location     = "us-central1"
+  region       = "us-central1"
   labels       = {
     label-one = "value-one"
   }

diff --git a/mmv1/third_party/terraform/tests/resource_vertex_ai_endpoint_test.go b/mmv1/third_party/terraform/tests/resource_vertex_ai_endpoint_test.go
@@ -45,7 +45,7 @@ func TestAccVertexAIEndpoint_vertexAiEndpointNetwork(t *testing.T) {
 				ResourceName:            "google_vertex_ai_endpoint.endpoint",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"etag", "location"},
+				ImportStateVerifyIgnore: []string{"etag", "location", "region"},
 			},
 			{
 				Config: testAccVertexAIEndpoint_vertexAiEndpointNetworkUpdate(context),
@@ -54,7 +54,7 @@ func TestAccVertexAIEndpoint_vertexAiEndpointNetwork(t *testing.T) {
 				ResourceName:            "google_vertex_ai_endpoint.endpoint",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"etag", "location"},
+				ImportStateVerifyIgnore: []string{"etag", "location", "region"},
 			},
 		},
 	})
@@ -67,6 +67,7 @@ resource "google_vertex_ai_endpoint" "endpoint" {
   display_name = "sample-endpoint"
   description  = "A sample vertex endpoint"
   location     = "us-central1"
+  region       = "us-central1"
   labels       = {
     label-one = "value-one"
   }
@@ -114,6 +115,7 @@ resource "google_vertex_ai_endpoint" "endpoint" {
   display_name = "new-sample-endpoint"
   description  = "An updated sample vertex endpoint"
   location     = "us-central1"
+  region       = "us-central1"
   labels       = {
     label-two = "value-two"
   }