-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced the panic statement with error in google_secret_manager_secret_version
resource import function
#8923
Replaced the panic statement with error in google_secret_manager_secret_version
resource import function
#8923
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
…t-manager-version-import-panic
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample|TestAccMonitoringMonitoredProject_projectNumLongForm|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample|TestAccMonitoringMonitoredProject_projectNumShortForm|TestAccDataSourceGoogleServiceAccountAccessToken_basic |
Rerun these tests in REPLAYING mode to catch issues
|
@c2thorn Could you please review and merge this PR? |
…ret_version` resource import function (GoogleCloudPlatform#8923)
…ret_version` resource import function (GoogleCloudPlatform#8923)
Replaced the panic statement with an error in the
google_secret_manager_secret_version
resource import functionfixes hashicorp/terraform-provider-google#9666
Release Note Template for Downstream PRs (will be copied)