Replaced the panic statement with error in `google_secret_manager_sec…

…ret_version` resource import function (GoogleCloudPlatform#8923)
nevzheng · Sep 22, 2023 · 8e269ed · 8e269ed
1 parent 589e919
commit 8e269ed
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/mmv1/templates/terraform/custom_import/secret_version.go.erb b/mmv1/templates/terraform/custom_import/secret_version.go.erb
@@ -11,7 +11,7 @@
 
 	parts := secretRegex.FindStringSubmatch(name)
 	if len(parts) != 2 {
-		panic(fmt.Sprintf("Version name does not fit the format `projects/{{project}}/secrets/{{secret}}/versions/{{version}}`"))
+		return nil, fmt.Errorf("Version name does not fit the format `projects/{{project}}/secrets/{{secret}}/versions/{{version}}`")
 	}
 	if err := d.Set("secret", parts[1]); err != nil {
 		return nil, fmt.Errorf("Error setting secret: %s", err)