Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update bigquery transfer config #9212

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

obada-ab
Copy link
Contributor

@obada-ab obada-ab commented Oct 10, 2023

Dynamically add update mask for changed properties instead of having a static list of all updatable properties.

In the case of service_account_name, it is only added to the update mask if it was set to a non-null value, as service_account_name cannot be removed from a transfer config using the patch API.

Fixes hashicorp/terraform-provider-google#16033 and hashicorp/terraform-provider-google#16126

Release Note Template for Downstream PRs (will be copied)

bigquerydatatransfer: fixed an error when updating `google_bigquery_data_transfer_config` related to incorrect update masks

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 41 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 41 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3131
Passed tests 2814
Skipped tests: 316
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigqueryDataTransferConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigqueryDataTransferConfig[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccBigqueryDataTransferConfig
3 participants