Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update bigquery transfer config #1600

Conversation

modular-magician
Copy link
Collaborator

Dynamically add update mask for changed properties instead of having a static list of all updatable properties.

In the case of service_account_name, it is only added to the update mask if it was set to a non-null value, as service_account_name cannot be removed from a transfer config using the patch API.

Fixes hashicorp/terraform-provider-google#16033 and hashicorp/terraform-provider-google#16126

Release Note Template for Downstream PRs (will be copied)

bigquerydatatransfer: fixed an error when updating `google_bigquery_data_transfer_config` related to incorrect update masks

Derived from GoogleCloudPlatform/magic-modules#9212

[upstream:ba4e63a4266cd105f28fc58575fd69c165fab747]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner October 17, 2023 00:52
@modular-magician modular-magician requested review from iyabchen and removed request for a team October 17, 2023 00:52
@modular-magician modular-magician merged commit 95b3e03 into GoogleCloudPlatform:main Oct 17, 2023
@modular-magician modular-magician deleted the downstream-pr-ba4e63a4266cd105f28fc58575fd69c165fab747 branch November 18, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccBigqueryDataTransferConfig
1 participant