-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dcl version #9370
update dcl version #9370
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a separate PR for adding tests covering the changes?
This comment was marked as outdated.
This comment was marked as outdated.
I've added the remaining missing tests in this PR, they should run now. The following don't have tests:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 15 files changed, 1005 insertions(+), 114 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_assured_workloads_workload" "primary" {
partner = # value needed
partner_permissions {
assured_workloads_monitoring = # value needed
data_logs_viewer = # value needed
service_access_approver = # value needed
}
}
Resource: resource "google_gke_hub_feature_membership" "primary" {
configmanagement {
config_sync {
metrics_gcp_service_account_email = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccDataprocClusterIamPolicy|TestAccDataprocJobIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
There may need to be some follow-up to copy the assured workloads and gke hub tests over.
upgrade DCL to
v1.55.0
(pending release note writing)google_assured_workloads_workload
partner fields caused issues in DCL tests, so I did not include samples for themgoogle_gke_hub_feature_membership
testsRelease Note Template for Downstream PRs (will be copied)