Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto sync with Skaffold #3395

Closed
wants to merge 1 commit into from

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 17, 2019

This is WIP to introduce auto-sync configuration to Buildpacks artifacts.

This feature requires collaboration from the buildpacks that have to export the sync metadata and also that need to be able to build a container image used just for dev.

!!This is very early stage. Many things need to be improved!!

Signed-off-by: David Gageot [email protected]

@loosebazooka
Copy link
Member

@dgageot I think there might be some conflicts between this and #3382. Also, I'm curious about autosync being on by default (for jib at least).

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ae6f5ce). Click here to learn what that means.
The diff coverage is 18.75%.

Impacted Files Coverage Δ
pkg/skaffold/build/local/local.go 60% <0%> (ø)
pkg/skaffold/docker/image_util.go 0% <0%> (ø)
pkg/skaffold/build/buildpacks/lifecycle.go 63.46% <0%> (ø)
pkg/skaffold/build/buildpacks/metadata.go 11.11% <0%> (ø)
pkg/skaffold/sync/sync.go 65.82% <0%> (ø)
pkg/skaffold/build/cache/lookup.go 100% <100%> (ø)
pkg/skaffold/build/buildpacks/types.go 100% <100%> (ø)
pkg/skaffold/build/cache/hash.go 75.94% <100%> (ø)
pkg/skaffold/build/local/types.go 69.44% <100%> (ø)
pkg/skaffold/build/cache/cache.go 56.81% <100%> (ø)
... and 1 more

dgageot added a commit to dgageot/skaffold that referenced this pull request Dec 24, 2019
dgageot added a commit to dgageot/skaffold that referenced this pull request Jan 7, 2020
nkubala added a commit that referenced this pull request Jan 7, 2020
[buildpacks] Refactor code to simplify #3395
@dgageot dgageot force-pushed the auto-sync branch 2 times, most recently from d23ce78 to deb7fa9 Compare January 10, 2020 06:08
@dgageot dgageot force-pushed the auto-sync branch 6 times, most recently from b11ea23 to bd8fd9c Compare January 20, 2020 17:52
Signed-off-by: David Gageot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants