[buildpacks] Refactor code to simplify #3395 #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
Codecov Report
|
dgageot
changed the title
briandealwis
reviewed
Jan 7, 2020
There was a problem hiding this comment.
I'm uncertain about changing the passing of insecureRegistries to the runCtx as it leads to runner-specific context being bled outside of the runner. This part of the change doesn't seem to be actually necessary? Or perhaps the run-context should be moved up into pkg/skaffold?
|
@briandealwis I can remove that part. I've got a much bigger PR that tries to address that anyways. |
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
|
SGTM |
nkubala
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a refactoring of the codebase meant to simplify #3395.
Signed-off-by: David Gageot [email protected]