Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tmpcharts folder and helm generated .lock files from list of watched files #4181

Merged
merged 3 commits into from
May 19, 2020

Conversation

gsquared94
Copy link
Contributor

@gsquared94 gsquared94 commented May 14, 2020

Exclude tmpcharts folder and helm generated .lock files from list of watched files

Fixes: #3565
Description

helm dep up makes changes to the tmpcharts in addition to charts subdirectory within a chart package. It also modifies requirements.lock file (helm 2) and Chart.lock file (helm 3). So we exclude these file from the file change monitor when skipBuildDependencies is not set to true

This is consistent with existing behavior of excluding charts subdirectory similarly.

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #4181 into master will increase coverage by 0.90%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/helm.go 84.12% <100.00%> (+4.99%) ⬆️
pkg/skaffold/runner/logger.go 36.36% <0.00%> (-63.64%) ⬇️
cmd/skaffold/app/cmd/flags.go 89.47% <0.00%> (-10.53%) ⬇️
pkg/skaffold/kubernetes/log.go 34.14% <0.00%> (-4.80%) ⬇️
pkg/skaffold/runner/kind.go 100.00% <0.00%> (ø)
pkg/skaffold/runner/runner.go 0.00% <0.00%> (ø)
pkg/skaffold/errors/buildProblems.go 100.00% <0.00%> (ø)
pkg/skaffold/schema/v2beta3/upgrade.go 100.00% <0.00%> (ø)
pkg/skaffold/util/regex.go 100.00% <0.00%> (ø)
pkg/skaffold/debug/transform_go.go 84.48% <0.00%> (+0.16%) ⬆️
... and 19 more

@gsquared94 gsquared94 requested a review from tejal29 May 18, 2020 19:43
@tejal29 tejal29 self-assigned this May 18, 2020
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label May 19, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 19, 2020
@gsquared94 gsquared94 closed this May 19, 2020
@gsquared94 gsquared94 reopened this May 19, 2020
@tejal29 tejal29 merged commit 2cd9a56 into GoogleContainerTools:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold keeps rebuilding and redeploying a helm chart with dependencies
4 participants