Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes to kpt deployer docs and ordering #4694

Merged
merged 1 commit into from
Aug 18, 2020
Merged

small changes to kpt deployer docs and ordering #4694

merged 1 commit into from
Aug 18, 2020

Conversation

felixtran39
Copy link
Contributor

Related: #3904, #4689

Description
Small changes to comments and ordering to address comments left on #4689.

@yuwenma
Copy link
Contributor

yuwenma commented Aug 18, 2020

Thanks for the change! LGTMed

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #4694 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4694   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         340      340           
  Lines       13372    13372           
=======================================
  Hits         9785     9785           
  Misses       2980     2980           
  Partials      607      607           
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
pkg/skaffold/runner/new.go 67.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4425d88...04d377f. Read the comment docs.

@felixtran39 felixtran39 added the kokoro:run runs the kokoro jobs on a PR label Aug 18, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Aug 18, 2020
@MarlonGamez MarlonGamez changed the title small changes small changes to kpt deployer docs and ordering Aug 18, 2020
@MarlonGamez MarlonGamez merged commit 62049df into GoogleContainerTools:master Aug 18, 2020
@felixtran39 felixtran39 deleted the config branch August 19, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants