Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kpt as a deployer #3904

Closed
bgrant0607 opened this issue Apr 1, 2020 · 6 comments
Closed

Support kpt as a deployer #3904

bgrant0607 opened this issue Apr 1, 2020 · 6 comments

Comments

@bgrant0607
Copy link

https://github.com/GoogleContainerTools/kpt
https://googlecontainertools.github.io/kpt/

Similar to the kustomize+kubectl support:
https://skaffold.dev/docs/pipeline-stages/deployers/#deploying-with-kustomize

@tstromberg
Copy link
Contributor

+1 - we should do this.

@nkubala nkubala added this to the Icebox [P2+] milestone Sep 1, 2020
@nkubala nkubala added priority/p1 High impact feature/bug. and removed priority/p2 May take a couple of releases labels Sep 17, 2020
@nkubala nkubala modified the milestones: Icebox [P2+], v1.16.0 Sep 17, 2020
@jlewi
Copy link
Contributor

jlewi commented Dec 2, 2020

How will skaffold.yaml and kpt setters interact if at all? For example, when skaffold builds/deploys a kpt package will it update setters to reflect the most recent values?

I often use skaffold and kpt together. I often use skaffold to build my images and then update my kpt package to use the newly built image.

I usually do this by having skaffold output the image and then using kpt + yq to set it; e.g

skaffold build --kube-context=${CONTEXT} -v debug --file-output=image.json
kpt cfg set -R . image $(shell yq r image.json builds[0].tag )

Any thought about whether this is something skaffold should support out of box?

@yuwenma
Copy link
Contributor

yuwenma commented Dec 3, 2020

How will skaffold.yaml and kpt setters interact if at all? For example, when skaffold builds/deploys a kpt package will it update setters to reflect the most recent values?

I often use skaffold and kpt together. I often use skaffold to build my images and then update my kpt package to use the newly built image.

I usually do this by having skaffold output the image and then using kpt + yq to set it; e.g

skaffold build --kube-context=${CONTEXT} -v debug --file-output=image.json
kpt cfg set -R . image $(shell yq r image.json builds[0].tag )

Any thought about whether this is something skaffold should support out of box?

Hi Jeremy, skaffold and kpt setters are working independently right now, but we have plans to support what you need here. Basically, you would be able to define kpt setters as a config file and provide its path in skaffold.yaml kpt. For now, I think a bash script to automate the step would be most efficient.

@briandealwis briandealwis modified the milestones: v1.18.0, v1.19.0 Jan 25, 2021
@nkubala nkubala modified the milestones: v1.20.0-candidate, Backlog [P0/P1] Feb 9, 2021
@yuwenma
Copy link
Contributor

yuwenma commented Feb 22, 2021

The kpt has been added to skaffold as a deployer (stable version) and I think we can mark this issue done. Future changes related to render v2 is orthogonal to this request.

@yuwenma yuwenma closed this as completed Feb 22, 2021
@irvifa
Copy link

irvifa commented Jun 1, 2021

HI @yuwenma do we have documentation on how to use this through the Skaffold?

@yuwenma
Copy link
Contributor

yuwenma commented Jun 1, 2021

HI Yuwen Ma do we have documentation on how to use this through the Skaffold?

@irvifa You can try out these interactive codelabs:

And check this reference for full features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants