Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity check for kpt/kustomize preinstalled version #4959

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Sanity check for kpt/kustomize preinstalled version #4959

merged 1 commit into from
Oct 28, 2020

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Oct 28, 2020

Fixes: #4884 #3904
Merge after: 4958

Description
Check kpt and kustomize CLI version to make sure it satisfies the basic requirements.

@yuwenma yuwenma requested a review from a team as a code owner October 28, 2020 10:35
@yuwenma yuwenma requested a review from IsaacPD October 28, 2020 10:35
@google-cla google-cla bot added the cla: yes label Oct 28, 2020
@codecov
Copy link

codecov bot commented Oct 28, 2020 •
edited
Loading

Codecov Report

Merging #4959 into master will decrease coverage by 0.00%.
The diff coverage is 78.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4959      +/-   ##
==========================================
- Coverage   72.27%   72.27%   -0.01%     
==========================================
  Files         361      361              
  Lines       12603    12640      +37     
==========================================
+ Hits         9109     9135      +26     
- Misses       2821     2827       +6     
- Partials      673      678       +5
Impacted Files Coverage Δ
pkg/skaffold/deploy/kpt/kpt.go 73.92% <78.37%> (+0.67%) ⬆️
pkg/skaffold/docker/image.go 80.61% <0.00%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939b7c0...18187bc. Read the comment docs.

tejal29
tejal29 requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM expect for minor nits on error strings.

pkg/skaffold/deploy/kpt/kpt.go Outdated Show resolved Hide resolved
pkg/skaffold/deploy/kpt/kpt.go Outdated Show resolved Hide resolved
pkg/skaffold/deploy/kpt/kpt.go Outdated Show resolved Hide resolved
pkg/skaffold/deploy/kpt/kpt.go Outdated Show resolved Hide resolved
pkg/skaffold/deploy/kpt/kpt.go Outdated Show resolved Hide resolved
pkg/skaffold/deploy/kpt/kpt.go Show resolved Hide resolved
@IsaacPD IsaacPD removed their request for review October 28, 2020 17:45
@tejal29 tejal29 added the kokoro:force-run forces a kokoro re-run on a PR label Oct 28, 2020
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Oct 28, 2020
@MarlonGamez
Copy link
Contributor

Looks good, I'll merge the changes once kokoro is done

@tejal29
Copy link
Member

tejal29 commented Oct 28, 2020

Manually running kokoro here https://fusion.corp.google.com/invocation/18f9d0a4-3cd2-4137-bbfd-779da58d200b?target=skaffold%2Fpresubmit&drilldownTab=tests

@MarlonGamez MarlonGamez merged commit 49b8981 into GoogleContainerTools:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check the pre-installed kpt version to make sure it satisfy the basic requirements.
4 participants
@yuwenma @MarlonGamez @tejal29 @kokoro-team