fix: flaky parquet predicate suits #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
waynexia
commented
Oct 12, 2022
|
Not sure if it really fixes the flushing issue. afaik it's related to parquet2's |
|
Looks like the same fix lol. |
|
Also fix the related workaround inside |
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #307 +/- ##
===========================================
+ Coverage 84.25% 84.28% +0.02%
===========================================
Files 319 319
Lines 28954 28975 +21
===========================================
+ Hits 24396 24422 +26
+ Misses 4558 4553 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
done 😄 |
evenyag
reviewed
Oct 13, 2022
3 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix: flaky parquet predicate suits Signed-off-by: Ruihang Xia <[email protected]> * fix: change ParquetWriter::write_rows as well Signed-off-by: Ruihang Xia <[email protected]> Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruihang Xia [email protected]
I notice that some cases in
table/predicatewill panic, like https://github.com/GreptimeTeam/greptimedb/actions/runs/3232216860/jobs/5292594794I try to fix it by adding a
flushcall on closing. But I'm not sure if this is fixed 🫣 I've run it 10+ times in my local env and no more failure occur. Please let me know if it doesn't work.