Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed FileStreamer's end method to flush Parquet magic #163

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Fixed FileStreamer's end method to flush Parquet magic #163

merged 1 commit into from
Jul 26, 2022

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Jul 26, 2022

Closes #162

@codecov-commenter
Copy link

Codecov Report

Merging #163 (c49b497) into main (9d7f4d8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   73.53%   73.54%           
=======================================
  Files          78       78           
  Lines        3779     3780    +1     
=======================================
+ Hits         2779     2780    +1     
  Misses       1000     1000
Impacted Files Coverage Δ
src/write/stream.rs 88.00% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d7f4d8...c49b497. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title fix: FileStreamer's end method does not flush Parquet magic Fixed FileStreamer's end method to flush Parquet magic Jul 26, 2022
@jorgecarleitao jorgecarleitao merged commit 450d05c into jorgecarleitao:main Jul 26, 2022
@jorgecarleitao jorgecarleitao added the bug Something isn't working label Jul 26, 2022
@jorgecarleitao
Copy link
Owner

Thanks a lot 🙇 This has been released under 0.14.2.

@v0y4g3r v0y4g3r mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parquet2::write::stream::FileStreamer::end does not flush Parquet footer
3 participants
@v0y4g3r @codecov-commenter @jorgecarleitao