Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: linux: cpu: Add debug in public CpuValues #1056

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

patrickelectric
Copy link
Contributor

No description provided.

@@ -224,7 +224,7 @@ impl CpusWrapper {
}

/// Struct containing values to compute a CPU usage.
#[derive(Clone, Copy)]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering this is not user-facing, is there any reason for this change? I don't mind it but just curious what you're hoping to achieve.

Copy link
Contributor Author

@patrickelectric patrickelectric Sep 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was working on debugging cpu frequency feedback in a different pieces of hardware, and for a development point of view it did help having this debug :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Merging then. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit e28271b into GuillaumeGomez:master Sep 3, 2023
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants