Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: linux: cpu: Add debug in public CpuValues #1056

Merged
merged 1 commit into from
Sep 3, 2023
Merged

src: linux: cpu: Add debug in public CpuValues #1056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/linux/cpu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ impl CpusWrapper {
}

/// Struct containing values to compute a CPU usage.
#[derive(Clone, Copy)]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering this is not user-facing, is there any reason for this change? I don't mind it but just curious what you're hoping to achieve.

Copy link
Contributor Author

@patrickelectric patrickelectric Sep 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was working on debugging cpu frequency feedback in a different pieces of hardware, and for a development point of view it did help having this debug :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Merging then. Thanks!

#[derive(Clone, Copy, Debug)]
pub(crate) struct CpuValues {
user: u64,
nice: u64,
Expand Down
Loading