-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-cmd/bump: add --auto
flag
#18227
Conversation
59a7c24
to
4ac52a6
Compare
This will read from the tap's `.github/autobump.txt` when provided. See discussion at Homebrew/homebrew-core#183126.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start here! Doesn't need to block this PR but, as mentioned, would be nice to see this keeping track of failures and then opening a PR to edit the bump list.
That's the intention, but the way the code is currently written I have no idea how to tell if something failed 🙃 |
Co-authored-by: Markus Reiter <[email protected]>
@reitermarkus let me know if you have further questions/comments/objections here, since I'm inclined to just move this along (and fix remaining issues/add further improvements in subsequent PRs). |
@carlocab Agreed, merging, thanks for this! |
Good to go but blocked on a legit Documentation CI failure. |
Follow-up to Homebrew/brew#18227. Also, let's remove `continue-on-error` so it's more immediately obvious when this workflow fails.
Follow-up to Homebrew/brew#18227. Also, let's remove `continue-on-error` so it's more immediately obvious when this workflow fails.
Follow-up to Homebrew/brew#18227. Also, let's remove `continue-on-error` so it's more immediately obvious when this workflow fails.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This will read from the tap's
.github/autobump.txt
when provided.See discussion at Homebrew/homebrew-core#183126.