Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/bump: add --auto flag #18227

Merged
merged 4 commits into from
Sep 6, 2024
Merged

dev-cmd/bump: add --auto flag #18227

merged 4 commits into from
Sep 6, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Sep 2, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This will read from the tap's .github/autobump.txt when provided.

See discussion at Homebrew/homebrew-core#183126.

This will read from the tap's `.github/autobump.txt` when provided.

See discussion at Homebrew/homebrew-core#183126.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start here! Doesn't need to block this PR but, as mentioned, would be nice to see this keeping track of failures and then opening a PR to edit the bump list.

Library/Homebrew/dev-cmd/bump.rb Outdated Show resolved Hide resolved
@carlocab
Copy link
Member Author

carlocab commented Sep 2, 2024

would be nice to see this keeping track of failures and then opening a PR to edit the bump list.

That's the intention, but the way the code is currently written I have no idea how to tell if something failed 🙃

@reitermarkus reitermarkus self-assigned this Sep 2, 2024
Co-authored-by: Markus Reiter <[email protected]>
@carlocab
Copy link
Member Author

carlocab commented Sep 6, 2024

@reitermarkus let me know if you have further questions/comments/objections here, since I'm inclined to just move this along (and fix remaining issues/add further improvements in subsequent PRs).

@MikeMcQuaid
Copy link
Member

@carlocab Agreed, merging, thanks for this!

@MikeMcQuaid
Copy link
Member

Good to go but blocked on a legit Documentation CI failure.

@carlocab carlocab merged commit 7adf6b0 into master Sep 6, 2024
28 checks passed
@carlocab carlocab deleted the auto-bump branch September 6, 2024 12:16
carlocab added a commit to Homebrew/homebrew-core that referenced this pull request Sep 10, 2024
Follow-up to Homebrew/brew#18227.

Also, let's remove `continue-on-error` so it's more immediately obvious
when this workflow fails.
carlocab added a commit to Homebrew/homebrew-core that referenced this pull request Oct 1, 2024
Follow-up to Homebrew/brew#18227.

Also, let's remove `continue-on-error` so it's more immediately obvious
when this workflow fails.
carlocab added a commit to Homebrew/homebrew-core that referenced this pull request Oct 1, 2024
Follow-up to Homebrew/brew#18227.

Also, let's remove `continue-on-error` so it's more immediately obvious
when this workflow fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants