Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Install an unlinked formula via brew install if --overwrite is passed #18536

Conversation

boblail
Copy link
Contributor

@boblail boblail commented Oct 8, 2024

If the intention is to overwrite any existing links, then brew install should go on to install over an unlinked formula

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@boblail boblail force-pushed the lail/install-unlinked-formulae-when---overwrite-is-passed branch 5 times, most recently from d55bf34 to 84250b6 Compare October 8, 2024 19:43
@boblail
Copy link
Contributor Author

boblail commented Oct 8, 2024

Hm. I don't think I understand this "Do not report this issue: you are running in an unsupported configuration.\n" error — how it's related to my tests. Does it make sense to one of the maintainers?

@Bo98
Copy link
Member

Bo98 commented Oct 10, 2024

Try temporarily add --debug to see if you get a better error.

@boblail boblail force-pushed the lail/install-unlinked-formulae-when---overwrite-is-passed branch 2 times, most recently from 8ccbc90 to 3620436 Compare October 12, 2024 18:41
… is passed

If the intention is to overwrite any existing links, then `brew install` should go on to install over an unlinked formula
@boblail boblail force-pushed the lail/install-unlinked-formulae-when---overwrite-is-passed branch from 3620436 to a5db113 Compare October 12, 2024 18:51
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @boblail, makes sense!

@MikeMcQuaid MikeMcQuaid merged commit e066806 into Homebrew:master Oct 13, 2024
27 checks passed
@boblail
Copy link
Contributor Author

boblail commented Oct 14, 2024

Thanks again, Mike!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants