Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Box Sync.app #2673

Merged
merged 1 commit into from
Jan 28, 2014
Merged

Add Box Sync.app #2673

merged 1 commit into from
Jan 28, 2014

Conversation

tazran
Copy link
Contributor

@tazran tazran commented Jan 28, 2014

No description provided.

@vitorgalvao
Copy link
Member

Seeing as url doesn’t seem to point to a specific version, this cask should use version 'latest' and no_checksum. See an example.

Also, according to the naming rules, the file should be boxsync.rb, and the class Boxsync. We’re discussing those right now, but in the meantime we should stick to the current ones.

@vitorgalvao
Copy link
Member

Please see my previous comment for another needed change, regarding naming (apologies, I edited the comment right after posting, so you must’ve missed that).

After you make that change and squash your commits, we can merge this in.

@tazran
Copy link
Contributor Author

tazran commented Jan 28, 2014

Thanks for pointing that out @vitorgalvao.

Regarding the naming rules, the app website refers to the app as named 'Box Sync' as apposed to 'BoxSync'.

The full reference is 'Box Sync 4', perhaps it needs to change to box-sync4 and BoxSync4?

@vitorgalvao
Copy link
Member

We don’t reference the version number, in this repo. But you’re right, they do reference it as “Box Sync” on the text (and on the the html’s <title>), I only looked at the branding on the top left.

We can leave this as-is, then. Could you please squash your commits?

@fanquake
Copy link
Contributor

@tazran You'll have to have another go at squashing your commits.

fix version and checksum thanks to @vitorgalvao
@vitorgalvao
Copy link
Member

Thank you. Merged.

vitorgalvao added a commit that referenced this pull request Jan 28, 2014
@vitorgalvao vitorgalvao merged commit 651f1a3 into Homebrew:master Jan 28, 2014
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants