-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Canonical name == App bundle name #2659
Conversation
Every time I write something against or for this approach, I think of new arguments that actually change my opinion, so please bear with me, I’ll try to be brief. I started thinking this would not be a good idea, somewhat feeling there could be some cases where it’d break down — cases where you don’t have an app — when you install something and don’t see its effects on disk (plugins and drivers, for example). Then I realised we could name it the same as the file inside the downloaded package, naturally, and although that could lead to some of them having “installer” in the name, it should be sporadic enough to not matter. Those are all pretty minor, considering the advantages of your suggestion, though. It does make it more convenient and less prone to errors when creating a cask, except in cases like parallels, where the user would have to mandatorily install it, to see the name of the resulting app (since the installer is named Like I said, I’m not fully committed to calling one approach superior, but right now I’m more inclined to the current one, and wanted to get those arguments out. |
These are good points, though I think we are somewhat talking about different things:
|
Yes, that’s what I understood (and based my answer on).
And my point is exactly that how it is written on the homepage is more useful to someone that just found the app. Are we talking about the same app that is in homebrew-cask, though? Because that one is written as “cdto”, on its homepage.
I missed that. But is it irrelevant to installation? Because that was my point, being able to deduce the name of and install an app without having to search for it beforehand, with the sole purpose of figuring out the correct name.
Neither do I, we would not be able to do it even remotely efficiently anyway (in either approach).
Now that, that one I will not contest in any way, and you’re absolutely correct. To me, that’s the strongest and most objective reason found in both approaches. I can really get behind that. On another note, sometimes even the app’s website itself is inconsistent with what they call it (like Box Sync), so one of your initial points
Is even more valid then. Between this and the previous point, I’m sold on it. |
There's only one substantive change in this patch, which is that the Canonical App name is defined exactly by the name of the App bundle on disk. The suggestion that the author's website be consulted for orthography is removed.
@vitorgalvao , updated/squashed according to your v useful feedback. Yes, cdto is written in both forms on the author site. My plan is to achieve better Caskname standardization in 3-4 rounds. This is the simple round. I will definitely ping you on the next rounds as they are harder. But basically I don't care which side a rule falls on so long as we pick one. This project's power and size comes from the "drive-by" Cask author who commits 1 or 2 Casks. I want to make it super easy/fast/fun for that person. |
OK. I'm going to move forward on this. My ultimate goal is a script which suggests the cask name. |
doc: Canonical name == App bundle name
following up on Homebrew#2659, further steps toward an algorithmic derivation of Canonical Name from App Name. Also add two rules about hyphens which are implied and already followed by every Cask.
There's only one substantive change in this patch, which is
that the Canonical App name is defined exactly by the name
of the App bundle on disk. The suggestion that the author's
website be consulted for orthography is removed.
All but 18 Casks follow this rule already (if we leave aside
version numbers), so that's 98.3% compliance. I see this change
as documenting the de facto situation more clearly. The App name
on disk is in any case superior to consulting the website, as it is
less subject to misreading or artistic interpretation.
If this PR is accepted, I will
Once the naming rules are fully specified, I'll PR a script which
a Cask author can use to generate the Cask Name and Cask Class
from a given App name, using the same logic as the backend.