[WIP] Add wine-staging 2.0-rc1 #27551

yurikoles · 2016-12-09T16:12:18Z

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.

After making all changes to the cask:

brew cask audit --download {{cask_file}} is error-free.
brew cask style --fix {{cask_file}} reports no offenses.
The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

Named the cask according to the [token reference].
brew cask install {{cask_file}} worked successfully.
brew cask uninstall {{cask_file}} worked successfully.
Checked there are no [open pull requests] for the same cask.
Checked that the cask was not already refused in [closed issues].

I have problem with cask, install ends with message Error: pkg source file not found: '/usr/local/Caskroom/wine-staging/1.9.23/wine-staging--1.9.23.pkg'

Full logs here: https://gist.github.com/yurikoles/fd1f99586a46d41d654d62510de9bb78

miccal · 2016-12-09T16:38:12Z

Casks/wine-staging.rb

+  url "https://repos.wine-staging.com/macosx/i686/winehq-staging-#{version}.pkg"
+  name 'Wine-staging'
+  homepage 'https://www.wine-staging.com/'
+


Please add the line depends_on cask: 'xquartz' - see here.

miccal · 2016-12-09T16:39:07Z

Casks/wine-staging.rb

+  name 'Wine-staging'
+  homepage 'https://www.wine-staging.com/'
+
+  pkg "wine-staging--#{version}.pkg"


This should be pkg "winehq-staging-#{version}.pkg".

It now reports success install, but I can't run it, e.g.

LC_ALL=C wine -bash: wine: command not found ``

miccal · 2016-12-09T16:42:31Z

The pkg stanza requires an uninstall. Please add the following:

  uninstall pkgutil: [
                       'org.winehq.wine-staging',
                       'org.winehq.wine-staging-deps',
                       'org.winehq.wine-staging-deps64',
                       'org.winehq.wine-staging32',
                       'org.winehq.wine-staging64',
                     ]

fixes according to miccal.

yurikoles · 2016-12-09T16:50:33Z

@miccal thanx for your help.
Up & rebase. But still can't run it.

miccal · 2016-12-09T16:55:23Z

Does this need Wine to be installed also? If so, you will also need to add the line depends_on formula: 'wine'.

yurikoles · 2016-12-09T16:57:09Z

Wine-Staging is a bleeding-edge test branch of wine, it contains wine binary itself.

miccal · 2016-12-09T17:44:34Z

Does it work if you install the pkg manually?

yurikoles · 2016-12-09T18:10:08Z

Yes, but In this case I don't see any mention of "winehq" in pkgutil --pkgs. I don't see it either by installing the cask.

miccal · 2016-12-10T01:20:07Z

But you can run it when you install it manually? Do you have Xquartz installed?

yurikoles · 2016-12-10T01:44:32Z

@miccal yes, but it doesn't use it.

miccal · 2016-12-10T09:39:04Z

I installed this via brew cask install https://raw.githubusercontent.com/yurikoles/homebrew-cask/8f0463f8c16148e482cc04c7720f4e338d54bec8/Casks/wine-staging.rb on a machine running macOS 10.12.1 and Xquartz 2.7.11. It created an .app called Wine Staging.app, which when I run opens a Terminal window with the following output:

################################################################################
#                           Wine Is Not an Emulator                            #
################################################################################

 Welcome to wine-1.9.23 (Staging).

 In order to start a program:
   .exe: wine program.exe
   .msi: wine msiexec /i program.msi

 If you want to configure wine:
   winecfg

 To get information about app compatibility:
   appdb Program Name

-bash-4.4.5- /Users/USER [>

Running the suggested command wine --check-libs results in the output:

libcups.2.dylib: /usr/lib/libcups.2.dylib
libfreetype.6.dylib: /opt/x11/lib/libfreetype.6.dylib
libGL.1.dylib: /opt/x11/lib/libGL.1.dylib
libjpeg.62.dylib: /Applications/Wine Staging.app/Contents/Resources/wine/lib/libjpeg.62.dylib
libncurses.5.4.dylib: /usr/lib/libncurses.5.4.dylib
libnetapi.dylib: missing
libodbc.dylib: missing
libOSMesa.8.dylib: /opt/x11/lib/libOSMesa.8.dylib
libpcap.A.dylib: /usr/lib/libpcap.A.dylib
libpng15.15.dylib: /opt/x11/lib/libpng15.15.dylib
libtiff.5.dylib: /Applications/Wine Staging.app/Contents/Resources/wine/lib/libtiff.5.dylib
libtxc_dxtn.dylib: /Applications/Wine Staging.app/Contents/Resources/wine/lib/libtxc_dxtn.dylib
libX11.6.dylib: /opt/x11/lib/libX11.6.dylib
libX11-xcb.1.dylib: /opt/x11/lib/libX11-xcb.1.dylib
libXcomposite.1.dylib: /opt/x11/lib/libXcomposite.1.dylib
libXcursor.1.dylib: /opt/x11/lib/libXcursor.1.dylib
libXext.6.dylib: /opt/x11/lib/libXext.6.dylib
libXi.6.dylib: /opt/x11/lib/libXi.6.dylib
libXinerama.1.dylib: /opt/x11/lib/libXinerama.1.dylib
libXrandr.2.dylib: /opt/x11/lib/libXrandr.2.dylib
libXrender.1.dylib: /opt/x11/lib/libXrender.1.dylib
libxslt.1.dylib: /usr/lib/libxslt.1.dylib
libXxf86vm.1.dylib: /opt/x11/lib/libXxf86vm.1.dylib

However, if I open a new Terminal window and enter the same command I get -bash: wine: command not found as you did. So it seems that you MUST run the app Wine Staging.app and use the Terminal window that it opens.

Like yourself, I don't see any mention of "winehq" in pkgutil --pkgs.

In conclusion, I would say that the Cask installs successfully.

I hope all this helps.

miccal · 2016-12-10T09:42:53Z

Casks/wine-staging.rb

+                       'org.winehq.wine-staging-deps64',
+                       'org.winehq.wine-staging32',
+                       'org.winehq.wine-staging64',
+                     ]


Please add delete: "#{appdir}/Wine Staging.app" to the uninstall stanza.

Is this not uninstalled using pkgutil?

No - when I ran brew cask uninstall https://raw.githubusercontent.com/yurikoles/homebrew-cask/8f0463f8c16148e482cc04c7720f4e338d54bec8/Casks/wine-staging.rb it did not remove the app.

I did think that was weird, though.

Yeah, thats why I dont commit my wine-staging cask. Seems all those pkg dont appear in pkgutil --pkgs|grep wine after installing the pkg, though the pkg really include the 5 sub-pkg with the name mentioned above.

numbermaniac · 2016-12-15T01:01:57Z

However, if I open a new Terminal window and enter the same command I get -bash: wine: command not found as you did. So it seems that you MUST run the app Wine Staging.app and use the Terminal window that it opens.

This is because Wine Staging.app adds the wine binary to the path first when it opens Terminal. If you scroll up in the Terminal window, this is the code it runs first:

test "$?BASH_VERSION" = "0" || eval 'setenv() { export "$1=$2"; }'; setenv PATH "/Applications/Wine Staging.app/Contents/Resources/start/bin:/Applications/Wine Staging.app/Contents/Resources/wine/bin:$PATH"; winehelp --clear

If you add "/Applications/Wine Staging.app/Contents/Resources/start/bin:/Applications/Wine Staging.app/Contents/Resources/wine/bin:$PATH" to your path in .bash_source, then wine will always be available when you open a Terminal.

miccal · 2016-12-15T01:22:50Z

Thanks for that @numbermaniac.

As @palxex mentioned, the 5 packages do not appear in pkgutil --pkgs which then affects the uninstall as pointed out by @reitermarkus.

Ping @caskroom/maintainers - should we add this Cask?

vitorgalvao · 2016-12-15T20:01:34Z

I have no issue with the app having to be deleted separately. It seems to be fairly common in pkg casks, as for some reason many times they are left behind (sometimes even just an empty app bundle). If it leaves many other things behind, that's another matter.

I have no strong feelings one way or the other.

miccal · 2016-12-16T00:06:53Z

Whoops, thanks @vitorgalvao.

reitermarkus · 2016-12-16T19:13:42Z

@yurikoles, can you confirm this is working now?

numbermaniac · 2016-12-17T00:16:25Z

Casks/wine-staging.rb

@@ -0,0 +1,21 @@
+cask 'wine-staging' do
+  version '1.9.23'


Since this cask was created, the latest version has now become 2.0-rc1.

Assuming the rc1 refers to Release Candidate 1, I think we will keep it at he latest "stable" version for now.

Not correct, since whole 1.9-branch is considered as development version.

Updated to 2.0-rc1.

numbermaniac · 2016-12-17T00:23:46Z

Also, does this enable the 64-bit Wine option that is offered when installing manually?

miccal · 2016-12-17T00:25:52Z

Also, does this enable the 64-bit Wine option that is offered when installing manually?

@yurikoles can you confirm this? I do not have my testing machine available at the moment.

yurikoles · 2016-12-17T11:10:26Z

@miccal it doesn't install 64-bit version now.

miccal · 2016-12-17T11:38:35Z

Installing the pkg manually, you are presented with the following:

I am not sure how to select that option as a user choice via Cask.

adidalal · 2016-12-17T23:34:13Z

@miccal Homebrew/brew#1535
Ref: https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/pkg.md

miccal · 2016-12-18T00:12:33Z

Thanks @adidalal but I was under the impression that this does not allow the user to actually make a choice?

adidalal · 2016-12-18T01:50:41Z

No, I don't believe so - that wasn't the intention of the feature, though, more so to allow for "optional" components to be auto-selected and installed so that we can move away from installer :manual

numbermaniac · 2016-12-18T02:08:42Z

IMO 64-bit should just be enabled for everyone, there isn't much of a reason why you wouldn't want it.

miccal · 2016-12-18T10:08:41Z

Closed in favour of #27937.

yurikoles changed the title ~~add wine-staging 1.9.23~~ [WIP]add wine-staging 1.9.23 Dec 9, 2016

miccal reviewed Dec 9, 2016

View reviewed changes

add wine-staging 1.9.23;

8f0463f

fixes according to miccal.

miccal reviewed Dec 10, 2016

View reviewed changes

miccal added the awaiting user reply Issue needs response from a user. label Dec 10, 2016

miccal added the awaiting maintainer feedback Issue needs response from a maintainer. label Dec 15, 2016

Update wine-staging.rb

be8dcb7

miccal removed the awaiting user reply Issue needs response from a user. label Dec 15, 2016

appdir won’t be respected because it’s a pkg

ce48931

Update wine-staging.rb

c8e3ba2

reitermarkus removed the awaiting maintainer feedback Issue needs response from a maintainer. label Dec 16, 2016

reitermarkus added the awaiting user reply Issue needs response from a user. label Dec 16, 2016

numbermaniac reviewed Dec 17, 2016

View reviewed changes

miccal added 2 commits December 17, 2016 19:33

Update wine-staging.rb

836ed43

Update wine-staging.rb

caeedc8

miccal removed the awaiting user reply Issue needs response from a user. label Dec 17, 2016

miccal changed the title ~~[WIP]add wine-staging 1.9.23~~ [WIP] Add wine-staging 2.0-rc1 Dec 17, 2016

miccal mentioned this pull request Dec 18, 2016

Add wine-staging 2.0-rc1 #27937

Merged

8 tasks

miccal closed this Dec 18, 2016

Homebrew locked and limited conversation to collaborators May 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add wine-staging 2.0-rc1 #27551

[WIP] Add wine-staging 2.0-rc1 #27551

yurikoles commented Dec 9, 2016 •

edited by miccal

Loading

miccal Dec 9, 2016

miccal Dec 9, 2016

yurikoles Dec 9, 2016

miccal commented Dec 9, 2016 •

edited

Loading

yurikoles commented Dec 9, 2016 •

edited

Loading

miccal commented Dec 9, 2016

yurikoles commented Dec 9, 2016

miccal commented Dec 9, 2016

yurikoles commented Dec 9, 2016 •

edited

Loading

miccal commented Dec 10, 2016

yurikoles commented Dec 10, 2016

miccal commented Dec 10, 2016

miccal Dec 10, 2016 •

edited

Loading

reitermarkus Dec 10, 2016

miccal Dec 10, 2016 •

edited

Loading

palxex Dec 10, 2016 •

edited

Loading

numbermaniac commented Dec 15, 2016 •

edited

Loading

miccal commented Dec 15, 2016

vitorgalvao commented Dec 15, 2016

miccal commented Dec 16, 2016

reitermarkus commented Dec 16, 2016

numbermaniac Dec 17, 2016

miccal Dec 17, 2016

yurikoles Dec 17, 2016

miccal Dec 17, 2016

numbermaniac commented Dec 17, 2016

miccal commented Dec 17, 2016

yurikoles commented Dec 17, 2016

miccal commented Dec 17, 2016 •

edited

Loading

adidalal commented Dec 17, 2016

miccal commented Dec 18, 2016

adidalal commented Dec 18, 2016

numbermaniac commented Dec 18, 2016

miccal commented Dec 18, 2016

[WIP] Add wine-staging 2.0-rc1 #27551

[WIP] Add wine-staging 2.0-rc1 #27551

Conversation

yurikoles commented Dec 9, 2016 • edited by miccal Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miccal commented Dec 9, 2016 • edited Loading

yurikoles commented Dec 9, 2016 • edited Loading

miccal commented Dec 9, 2016

yurikoles commented Dec 9, 2016

miccal commented Dec 9, 2016

yurikoles commented Dec 9, 2016 • edited Loading

miccal commented Dec 10, 2016

yurikoles commented Dec 10, 2016

miccal commented Dec 10, 2016

miccal Dec 10, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miccal Dec 10, 2016 • edited Loading

Choose a reason for hiding this comment

palxex Dec 10, 2016 • edited Loading

Choose a reason for hiding this comment

numbermaniac commented Dec 15, 2016 • edited Loading

miccal commented Dec 15, 2016

vitorgalvao commented Dec 15, 2016

miccal commented Dec 16, 2016

reitermarkus commented Dec 16, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

numbermaniac commented Dec 17, 2016

miccal commented Dec 17, 2016

yurikoles commented Dec 17, 2016

miccal commented Dec 17, 2016 • edited Loading

adidalal commented Dec 17, 2016

miccal commented Dec 18, 2016

adidalal commented Dec 18, 2016

numbermaniac commented Dec 18, 2016

miccal commented Dec 18, 2016

yurikoles commented Dec 9, 2016 •

edited by miccal

Loading

miccal commented Dec 9, 2016 •

edited

Loading

yurikoles commented Dec 9, 2016 •

edited

Loading

yurikoles commented Dec 9, 2016 •

edited

Loading

miccal Dec 10, 2016 •

edited

Loading

miccal Dec 10, 2016 •

edited

Loading

palxex Dec 10, 2016 •

edited

Loading

numbermaniac commented Dec 15, 2016 •

edited

Loading

miccal commented Dec 17, 2016 •

edited

Loading