Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wine-staging 2.0-rc1 #27937

Merged
merged 2 commits into from
Dec 19, 2016
Merged

Add wine-staging 2.0-rc1 #27937

merged 2 commits into from
Dec 19, 2016

Conversation

miccal
Copy link
Contributor

@miccal miccal commented Dec 18, 2016

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the [token reference].
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no [open pull requests] for the same cask.
  • Checked that the cask was not already refused in [closed issues].

Continuing #27551.

I have added the 64-bit Wine option as a default.

Ping @vitorgalvao for comments and approval.

@miccal miccal mentioned this pull request Dec 18, 2016
8 tasks
@miccal
Copy link
Contributor Author

miccal commented Dec 18, 2016

Installing the pkg manually, you are presented with the following:

4c3d27a8-c490-11e6-9775-454ccfa526b0

Output of installer -showChoicesXML -pkg '/Users/miccal/Downloads/winehq-staging-2.0-rc1.pkg':

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<array>
	<dict>
		<key>childItems</key>
		<array>
			<dict>
				<key>childItems</key>
				<array/>
				<key>choiceDescription</key>
				<string>Third party libraries which are required for Wine.</string>
				<key>choiceIdentifier</key>
				<string>choice0</string>
				<key>choiceIsEnabled</key>
				<false/>
				<key>choiceIsSelected</key>
				<integer>1</integer>
				<key>choiceIsVisible</key>
				<true/>
				<key>choiceSizeInKilobytes</key>
				<integer>50088</integer>
				<key>choiceTitle</key>
				<string>Dependencies</string>
				<key>pathsOfActivePackagesInChoice</key>
				<array>
					<string>file://localhost/Users/miccal/Downloads/winehq-staging-2.0-rc1.pkg#org.winehq.wine-staging-deps.pkg</string>
				</array>
			</dict>
			<dict>
				<key>childItems</key>
				<array/>
				<key>choiceDescription</key>
				<string>Support for running 32 bit applications in Wine.</string>
				<key>choiceIdentifier</key>
				<string>choice1</string>
				<key>choiceIsEnabled</key>
				<false/>
				<key>choiceIsSelected</key>
				<integer>1</integer>
				<key>choiceIsVisible</key>
				<true/>
				<key>choiceSizeInKilobytes</key>
				<integer>215840</integer>
				<key>choiceTitle</key>
				<string>32 bit support</string>
				<key>pathsOfActivePackagesInChoice</key>
				<array>
					<string>file://localhost/Users/miccal/Downloads/winehq-staging-2.0-rc1.pkg#org.winehq.wine-staging.pkg</string>
				</array>
			</dict>
			<dict>
				<key>childItems</key>
				<array/>
				<key>choiceDescription</key>
				<string>Files that are only required for non WOW 64 support.</string>
				<key>choiceIdentifier</key>
				<string>choice2</string>
				<key>choiceIsEnabled</key>
				<false/>
				<key>choiceIsSelected</key>
				<integer>1</integer>
				<key>choiceIsVisible</key>
				<false/>
				<key>choiceSizeInKilobytes</key>
				<integer>39892</integer>
				<key>choiceTitle</key>
				<string>32 bit only files</string>
				<key>pathsOfActivePackagesInChoice</key>
				<array>
					<string>file://localhost/Users/miccal/Downloads/winehq-staging-2.0-rc1.pkg#org.winehq.wine-staging32.pkg</string>
				</array>
			</dict>
			<dict>
				<key>childItems</key>
				<array/>
				<key>choiceDescription</key>
				<string>Support for running 64 bit applications in Wine.</string>
				<key>choiceIdentifier</key>
				<string>choice3</string>
				<key>choiceIsEnabled</key>
				<true/>
				<key>choiceIsSelected</key>
				<integer>0</integer>
				<key>choiceIsVisible</key>
				<true/>
				<key>choiceSizeInKilobytes</key>
				<integer>266616</integer>
				<key>choiceTitle</key>
				<string>64 bit support (experimental)</string>
				<key>pathsOfActivePackagesInChoice</key>
				<array>
					<string>file://localhost/Users/miccal/Downloads/winehq-staging-2.0-rc1.pkg#org.winehq.wine-staging64.pkg</string>
					<string>file://localhost/Users/miccal/Downloads/winehq-staging-2.0-rc1.pkg#org.winehq.wine-staging-deps64.pkg</string>
				</array>
			</dict>
		</array>
		<key>choiceIdentifier</key>
		<string>__ROOT_CHOICE_IDENT_Wine Staging</string>
		<key>choiceIsEnabled</key>
		<true/>
		<key>choiceIsSelected</key>
		<integer>-1</integer>
		<key>choiceIsVisible</key>
		<true/>
		<key>choiceSizeInKilobytes</key>
		<integer>0</integer>
		<key>choiceTitle</key>
		<string>Wine Staging</string>
		<key>pathsOfActivePackagesInChoice</key>
		<array/>
	</dict>
</array>
</plist>

@yurikoles
Copy link
Contributor

yurikoles commented Dec 18, 2016

@miccal there is an error

Error: Command failed to execute!

==> Failed command:
/usr/bin/sudo -E -- /usr/sbin/installer -pkg #<Pathname:/usr/local/Caskroom/wine-staging/2.0-rc1/winehq-staging-2.0-rc1.pkg> -target / -applyChoiceChangesXML /var/folders/3k/z840g9t92hn7d9grbtpw7wd40000gn/T/choices20161218-3999-avjoyb.xml

==> Standard Output of failed command:
installer: Package name is Wine Staging
installer: choices file '/var/folders/3k/z840g9t92hn7d9grbtpw7wd40000gn/T/choices20161218-3999-avjoyb.xml' either could not be found or was malformed.

==> Standard Error of failed command:

@miccal
Copy link
Contributor Author

miccal commented Dec 18, 2016

@yurikoles try again please with brew cask install https://raw.githubusercontent.com/miccal/homebrew-cask/2d92a13736bd9356ec0218081e3e620a45a3b31c/Casks/wine-staging.rb.

@yurikoles
Copy link
Contributor

@miccal it works now.

@miccal
Copy link
Contributor Author

miccal commented Dec 18, 2016

Yay!

@miccal
Copy link
Contributor Author

miccal commented Dec 18, 2016

@vitorgalvao a question to satisfy my curiosity: why are square brackets and braces required in choices:? My initial PR did not have the square brackets, and the Cask failed to install.

@numbermaniac
Copy link
Contributor

numbermaniac commented Dec 18, 2016

It's a list of lists. Because if you had to select multiple options, the [] would enclose all of them, and you'd surround the three settings for each option with {}. An example.

@miccal
Copy link
Contributor Author

miccal commented Dec 18, 2016

Yes but it is not a list of lists in this case - there is only one set of braces.

@numbermaniac
Copy link
Contributor

The idea is that one {} brace means one option, and within that, you need to have your 3 settings. That has to be encased in [] because there can be multiple options to turn on in the pkg.

@miccal
Copy link
Contributor Author

miccal commented Dec 18, 2016

Thanks @numbermaniac, now I get it.

@miccal miccal merged commit 51b65f6 into Homebrew:master Dec 19, 2016
@miccal miccal deleted the wine-staging branch December 19, 2016 20:29
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants