Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop non-alpnanumeric chars from Canonical Name #3175

Merged

Conversation

rolandwalker
Copy link
Contributor

following up on #2659, further steps toward an algorithmic
derivation of Canonical Name from App Name.

Also add two rules about hyphens which are implied and already
followed by every Cask.

following up on Homebrew#2659, further steps toward an algorithmic
derivation of Canonical Name from App Name.

Also add two rules about hyphens which are implied and already
followed by every Cask.
@rolandwalker
Copy link
Contributor Author

Paging @vitorgalvao for your review/opinions.

Having completed renames to become consistent with #2659, this is my next proposed step in defining the Canonical Name: delete non-alphanumeric characters.

The source of this rule (as before) is that this seems to be the general behavior of existing Casks. Enforcing this change would mean changing two current Cask names: tune-instructor.rb and join-me.rb.

Background & goals:

  • fully define the steps to derive a Cask name
  • provide a script which automates the steps
  • simplify CONTRIBUTING.md by referring users to the naming script
  • integrate the naming script with brew cask create
  • reduce chance of duplicate submissions

@rolandwalker
Copy link
Contributor Author

Moving forward, as this only affects 2 Casks.

rolandwalker added a commit that referenced this pull request Feb 27, 2014
drop non-alpnanumeric chars from Canonical Name
@rolandwalker rolandwalker merged commit dd88c5e into Homebrew:master Feb 27, 2014
@rolandwalker rolandwalker deleted the doc_cask_name_drop_characters branch February 27, 2014 13:05
@rolandwalker rolandwalker mentioned this pull request Jun 4, 2014
87 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant