rust 1.72.0 #140367
Merged
rust 1.72.0 #140367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bump-formula-pr
ZhongRuoyu
added
CI-long-timeout
github-actions
bot
removed
the
CI-long-timeout
ZhongRuoyu
force-pushed
the
bump-rust-1.72.0
branch
from
a0a3149 to
4cb9303
Compare
ZhongRuoyu
added
the
CI-long-timeout
This comment was marked as resolved.
This comment was marked as resolved.
ZhongRuoyu
force-pushed
the
bump-rust-1.72.0
branch
from
4cb9303 to
fe5b470
Compare
ZhongRuoyu
commented
Aug 24, 2023
ZhongRuoyu
force-pushed
the
bump-rust-1.72.0
branch
2 times, most recently
from
9c70ef5 to
1edffc8
Compare
cho-m
reviewed
Aug 24, 2023
6 tasks
ZhongRuoyu
added a commit
to ZhongRuoyu/homebrew-core
that referenced
this pull request
Aug 25, 2023
This resolves the circular dependency in Homebrew#140367. See: Homebrew#140367 (comment)
Moisan
removed
the
CI-long-timeout
github-actions
bot
added
the
CI-long-timeout
|
Cancelled CI as it took unusually long. Turned out that all runners were stuck at |
github-actions
bot
removed
the
CI-long-timeout
chenrui333
force-pushed
the
bump-rust-1.72.0
branch
from
1edffc8 to
e391332
Compare
|
update cargo to 0.73.1 |
|
gonna check out sh4d0wup to see if it builds out fine before next rerun. |
chenrui333
added a commit
to Homebrew/formula-patches
that referenced
this pull request
Aug 27, 2023
relates to Homebrew/homebrew-core#140367 Signed-off-by: Rui Chen <[email protected]>
ZhongRuoyu
force-pushed
the
bump-rust-1.72.0
branch
from
e391332 to
3aa4816
Compare
|
The failures above are non-blocking as they don't affect the existing bottles. I've pushed a final update to finish this off (cleanups + unbundling |
ZhongRuoyu
commented
Aug 31, 2023
github-actions
bot
removed
the
CI-long-timeout
chenrui333
approved these changes
Aug 31, 2023
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
CI-build-dependents-from-source
ZhongRuoyu
added a commit
to ZhongRuoyu/homebrew-core
that referenced
this pull request
Aug 31, 2023
`rust` no longer ships `rust-analyzer` and `rustfmt` since Homebrew#140367.
ZhongRuoyu
added a commit
to ZhongRuoyu/homebrew-core
that referenced
this pull request
Aug 31, 2023
`rust` no longer ships `rust-analyzer` and `rustfmt` since Homebrew#140367.
ZhongRuoyu
added a commit
to ZhongRuoyu/homebrew-core
that referenced
this pull request
Aug 31, 2023
`rust` no longer ships `rust-analyzer` and `rustfmt` since Homebrew#140367.
6 tasks
ZhongRuoyu
commented
Aug 31, 2023
Comment on lines
28
to
36
| bottle do | ||
| sha256 cellar: :any, arm64_ventura: "ebb7606e866133436ba0f6914746dd08ba07551a83887ac475540d705cc45d00" | ||
| sha256 cellar: :any, arm64_monterey: "14c396c71bfc85ec4dceb235cc4142b4484c31736b99bf5ee5cc2be9f3d548cd" | ||
| sha256 cellar: :any, arm64_big_sur: "c2cf1974f723423d73588c4bd2d3ffe1d27e88c3e78506aa63da4ceb06b15cdf" | ||
| sha256 cellar: :any, ventura: "cf17622b469fd267981d97613d204196ec3725e54d25561a4e13df3ec9543426" | ||
| sha256 cellar: :any, monterey: "639a24c8f7460ba1c18488505605b05f172879e2b972045cdb38b8dfd809edbe" | ||
| sha256 cellar: :any, big_sur: "e204be3861c7f7df3f9ae0d56ffb1e41f0c865157784eb25933d2510ad0fa5d1" | ||
| sha256 cellar: :any_skip_relocation, x86_64_linux: "6ab9ba5c6d96bf35e29d7d95756f02c0e29a661e3907b4d08a0e85a6996b4686" | ||
| sha256 arm64_ventura: "28e026c3d24f6dce2c1fb5087cf35cc5ffd88aa9055de215b81ae33d17e1f33b" | ||
| sha256 arm64_monterey: "9a1ee1b72f0e6c6a0c1aa4d44de57ad18616710233c18e1e24960b9219d448aa" | ||
| sha256 arm64_big_sur: "7a65f06827c04b4d5ec27ff88efd143bc970081225eede6db71d2ce888ddf6ef" | ||
| sha256 ventura: "dbc20ef5f433182b31d7b2bf0f2bb29c96abcf2ecf2cccfc00c9774b46c27038" | ||
| sha256 monterey: "2a0ec660efed84e2ccfaaed4c30d2fc0577cbb9a41df32b374d8706202793837" | ||
| sha256 big_sur: "daaa3f24643f928e4098dae014c9e2055057a05f4c12710b837991808c59b193" | ||
| sha256 cellar: :any_skip_relocation, x86_64_linux: "1701167773a55ba430ef5c318cb951f38041387949aed7f37a43b909e78a607c" | ||
| end |
There was a problem hiding this comment.
As a side effect of using brewed llvm, we've lost relocatable bottles on macOS. 🥲
==> Detecting if rust--1.72.0.ventura.bottle.tar.gz is relocatable...
Warning: String '/usr/local/opt' still exists in these files:
/usr/local/Cellar/rust/1.72.0/lib/librustc_driver-d7af7c52e7c23764.dylib
--> links to /usr/local/opt/llvm/lib/libLLVM.dylib
The path to llvm-config is hardcoded in https://github.com/rust-lang/rust/blob/1.72.0/compiler/rustc_codegen_llvm/src/context.rs#L169-L196.
Closed
This was referenced Oct 26, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, implement the following based on discussion in Slack:
cargobuild and installation by replacing the copy in the original source.llvm,libgit2, andlibssh2.rust-analyzerandrustfmtand revive the respective formulae.Failures: #140367 (comment)