Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarinet 1.8.0 #142106

Conversation

blockstack-devops
Copy link
Contributor

Created with brew bump-formula-pr.

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Sep 12, 2023
@chenrui333
Copy link
Member

cc @hugocaillard

@hugocaillard
Copy link
Contributor

Hey @chenrui333
We kind of expected the build to fail here, so no surprise.

We have new compile issue that occurs with Rust v1.72.0 (as it was mentioned #140367 (comment)).

On our CI, we are building and releasing clarinet with a fixed rust version (1.71.0), is it possible to do the same on Homebrew?

A bit of context

It a new problem, not the same we had in the 1.6.x releases. But similar because it impacts the old version of deno-core / v8 we are using in this project.

So the work to get rid of this dependencies is in progress and we'll soon release Clarinet 2 without this annoying dependencies everything will be fixed

@chenrui333
Copy link
Member

On our CI, we are building and releasing clarinet with a fixed rust version (1.71.0), is it possible to do the same on Homebrew?

we cannot accommodate that, sorry.

@chenrui333
Copy link
Member

So the work to get rid of this dependencies is in progress and we'll soon release Clarinet 2 without this annoying dependencies everything will be fixed

if that is the case, we might better wait for Clarinet 2, what do you think?

@hugocaillard
Copy link
Contributor

@chenrui333 ok thanks for your help.
I was asking in case there was a setting for the rust version.

Let's focus on clarinet 2 then 💪

We can close this PR

@chenrui333
Copy link
Member

Cool, cool, thanks for your understanding. 🚀

@chenrui333 chenrui333 closed this Sep 14, 2023
@chenrui333 chenrui333 mentioned this pull request Sep 15, 2023
@Moisan Moisan mentioned this pull request Sep 19, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants