Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icu4c 65.1 #48349

Closed
wants to merge 42 commits into from
Closed

icu4c 65.1 #48349

wants to merge 42 commits into from

Conversation

fxcoudert
Copy link
Member

Let's go ⏱

@fxcoudert fxcoudert mentioned this pull request Dec 28, 2019
@fxcoudert
Copy link
Member Author

fxcoudert commented Dec 29, 2019

09:47:57 Undefined symbols for architecture x86_64:
09:47:57   "boost::filesystem::detail::directory_iterator_construct(boost::filesystem::directory_iterator&, boost::filesystem::path const&, boost::system::error_code*)", referenced from:
09:47:57       boost::filesystem::directory_iterator::directory_iterator(boost::filesystem::path const&) in build-dict.cc.o

@fxcoudert fxcoudert mentioned this pull request Dec 29, 2019
@bayandin bayandin mentioned this pull request Jan 7, 2020
@SMillerDev
Copy link
Member

Was the freeling error reported upstream? I see some "fix macOS" commits in their history. Other than that I think this is ready for a rebase/rebuild

@fxcoudert
Copy link
Member Author

  • mapnik has not been fixed
  • freeling issue is Boost, I think, not macOS-specific. I will report it.

I don't really see the point in rebasing (and having CI take another 2 days) given two of the formulas don't even build.

@SMillerDev
Copy link
Member

I thought mapnik was fixed which would make the rebase "ready to merge" my bad

@fxcoudert
Copy link
Member Author

I've tried to apply the mapnik master patches to 3.0.22 sources, but it fails. If mapnik continues to hold updates for a long time, because they do not fix issues, it may become time to remove it from Homebrew. It has many users, sadly, but nothing depends on it.

@fxcoudert
Copy link
Member Author

Mapnik fix in #49355

@stale
Copy link

stale bot commented Feb 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Feb 14, 2020
@fxcoudert fxcoudert removed the stale No recent activity label Feb 21, 2020
@stale
Copy link

stale bot commented Mar 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Mar 6, 2020
@Bo98
Copy link
Member

Bo98 commented Mar 6, 2020

Does the freeling thing still happen? I cannot reproduce locally.

Not sure what's up with mapnik 3.0.23 (#50582) but I'll have a look this weekend.

@stale stale bot removed the stale No recent activity label Mar 6, 2020
@Bo98
Copy link
Member

Bo98 commented Mar 6, 2020

Ok, the freeling thing happens if Homebrew's Boost is installed. It's because it gets mixed up between the libraries built from the Boost resource and the ones available globally. Not entirely sure why Boost is built from a resource here since there's no comment explaining why.

@iMichka
Copy link
Member

iMichka commented Mar 6, 2020

Probably because of this: #16737

@Bo98
Copy link
Member

Bo98 commented Mar 7, 2020

I read that wrong at first. Is it just to avoid using options? If that's the case then it doesn't apply anymore.

@samford
Copy link
Member

samford commented Mar 12, 2020

Just a heads up, the newest version is now 66.1 (as of 2020/03/11).

@iMichka iMichka mentioned this pull request Mar 22, 2020
5 tasks
@Bo98 Bo98 mentioned this pull request Mar 24, 2020
5 tasks
@stale
Copy link

stale bot commented Apr 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Apr 2, 2020
@iMichka
Copy link
Member

iMichka commented Apr 3, 2020

Superseded by #52481

@iMichka iMichka closed this Apr 3, 2020
@Bo98 Bo98 mentioned this pull request Apr 6, 2020
5 tasks
@lock lock bot added the outdated PR was locked due to age label May 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
@fxcoudert fxcoudert deleted the icu4c-65.1 branch October 12, 2020 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants