Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icu4c 66.1 #52025

Closed
wants to merge 45 commits into from
Closed

Icu4c 66.1 #52025

wants to merge 45 commits into from

Conversation

pOmelchenko
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Updated icu4c and all dependent formulas.

P.S.: I hope that on second try I will made all right ☺️

@pOmelchenko
Copy link
Contributor Author

Who can help with solving problems? I was think I made all correct but CI failed and now I don't understand what happens

@Bo98
Copy link
Member

Bo98 commented Mar 23, 2020

These still need revision bumping:

  • gjs
  • ncmpcpp
  • vte3

@pOmelchenko
Copy link
Contributor Author

These still need revision bumping:

  • gjs
  • ncmpcpp
  • vte3

Thx! But why? I don't see relations with icu4c

@Bo98
Copy link
Member

Bo98 commented Mar 23, 2020

The CI detected that the current bottles are linking against icu4c (via brew linkage --test). It is likely the case that icu4c is there as a dependency of another dependency. Arguably there should be a depends_on "icu4c" there to be more implicit, but no one noticed since it was being pulled in as a dependency anyway.

For example, ncmpcpp depends on boost which depends on icu4c. icu4c is therefore a dependency of ncmpcpp because boost needs it, but ncmpcpp happens to also actually use icu4c directly.

@pOmelchenko
Copy link
Contributor Author

I'm understood, thank you

@pOmelchenko
Copy link
Contributor Author

Guys, I need help, again. I'm right in my mind about dependents? If I run that command brew uses icu4c --recursive I got full list of packages which I must bumping for correct building?

I'm not sure but I got list of 450+ names. It's really correct?

@Bo98
Copy link
Member

Bo98 commented Mar 24, 2020

No you don't need to revision bump every single one. In some cases, you might not even need to do every one at the first level brew uses. The best way really is to see what the CI says.

It looks like you've covered everything, but it's just that some of them, like mapnik, have compile errors. See #48349 for a previous attempt. It looks like not much has changed since.

@SMillerDev
Copy link
Member

Mapnik had a release since then. Updating a release is preferable over version bumping

@pOmelchenko pOmelchenko closed this Apr 2, 2020
@pOmelchenko pOmelchenko deleted the icu4c-66.1 branch April 2, 2020 22:07
@lock lock bot added the outdated PR was locked due to age label May 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants