node 14.0.0 #53494

billinghamj · 2020-04-21T17:21:58Z

Created with brew bump-formula-pr.

issyl0 · 2020-04-21T17:37:09Z

Thanks for this PR!

ERROR: icu4c v64.2 is too old, v65.x or later is required.

This depends on the in-progress (ish) #52481 for the newest version of icu4c. So I guess it's a waiting game.

billinghamj · 2020-04-21T18:04:43Z

👋 Haven't seen you for a veeeery long time! :)

issyl0 · 2020-04-21T18:20:17Z

I was thinking that too! Hi, James! 👋

SMillerDev · 2020-04-22T05:08:34Z

No, we're all volunteers here. A maintainer will get to it when they have time.

billinghamj · 2020-04-22T08:15:17Z

Looks like currently dependent on #52481 & #53506. Shouldn't take too long :)

And of course you can always edit your local version in the meantime - brew edit node I believe

billinghamj · 2020-04-23T15:00:20Z

Rebased. Should be good to go now I think!

billinghamj · 2020-04-23T16:58:40Z

It seems like bcoin and joplin failed. Not entirely clear why though

billinghamj · 2020-04-23T17:03:18Z

❯ brew test --verbose bcoin
Testing bcoin
/usr/bin/sandbox-exec -f /private/tmp/homebrew20200423-9561-u62kyq.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/bcoin.rb --verbose
==> /usr/local/opt/node/bin/node /private/tmp/bcoin-test-20200423-9562-q6peq3/script.js
/usr/local/Cellar/bcoin/2.0.0/libexec/lib/node_modules/bcoin/node_modules/loady/lib/loady.js:109
      throw e;
      ^

Error: Module did not self-register: '/usr/local/Cellar/bcoin/2.0.0/libexec/lib/node_modules/bcoin/node_modules/bcrypto/build/Release/bcrypto.node'.
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1235:18)
    at Module.load (internal/modules/cjs/loader.js:1034:32)
    at Function.Module._load (internal/modules/cjs/loader.js:923:14)
    at Module.require (internal/modules/cjs/loader.js:1074:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at bindings (/usr/local/Cellar/bcoin/2.0.0/libexec/lib/node_modules/bcoin/node_modules/loady/lib/loady.js:98:17)
    at Object.<anonymous> (/usr/local/Cellar/bcoin/2.0.0/libexec/lib/node_modules/bcoin/node_modules/bcrypto/lib/native/binding.js:14:33)
    at Module._compile (internal/modules/cjs/loader.js:1185:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1205:10)
    at Module.load (internal/modules/cjs/loader.js:1034:32)
Error: bcoin: failed
Failed executing:
/usr/local/Homebrew/Library/Homebrew/formula.rb:1987:in `block in system'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1925:in `open'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1925:in `system'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/bcoin.rb:37:in `block in <class:Bcoin>'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1795:in `block (3 levels) in run_test'
/usr/local/Homebrew/Library/Homebrew/utils.rb:474:in `with_env'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1794:in `block (2 levels) in run_test'
/usr/local/Homebrew/Library/Homebrew/formula.rb:867:in `with_logging'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1793:in `block in run_test'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2037:in `block in mktemp'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:57:in `block in run'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:57:in `chdir'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:57:in `run'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2036:in `mktemp'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1787:in `run_test'
/usr/local/Homebrew/Library/Homebrew/test.rb:35:in `block in <main>'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:93:in `block in timeout'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `block in catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:108:in `timeout'
/usr/local/Homebrew/Library/Homebrew/test.rb:34:in `<main>'

billinghamj · 2020-04-23T17:15:29Z

❯ brew test --verbose joplin
Testing joplin
/usr/bin/sandbox-exec -f /private/tmp/homebrew20200423-16893-dmhyk.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/joplin.rb --verbose
==> /usr/local/Cellar/joplin/1.0.163/bin/joplin config editor subl
internal/modules/cjs/loader.js:1017
  throw err;
  ^

Error: Cannot find module '/usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/node_modules/sqlite3/lib/binding/node-v83-darwin-x64/node_sqlite3.node'
Require stack:
- /usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/node_modules/sqlite3/lib/sqlite3.js
- /usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/lib/database-driver-node.js
- /usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/lib/BaseApplication.js
- /usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/app.js
- /usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/main.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1014:15)
    at Function.Module._load (internal/modules/cjs/loader.js:884:27)
    at Module.require (internal/modules/cjs/loader.js:1074:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/node_modules/sqlite3/lib/sqlite3.js:4:15)
    at Module._compile (internal/modules/cjs/loader.js:1185:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1205:10)
    at Module.load (internal/modules/cjs/loader.js:1034:32)
    at Function.Module._load (internal/modules/cjs/loader.js:923:14)
    at Module.require (internal/modules/cjs/loader.js:1074:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/node_modules/sqlite3/lib/sqlite3.js',
    '/usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/lib/database-driver-node.js',
    '/usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/lib/BaseApplication.js',
    '/usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/app.js',
    '/usr/local/Cellar/joplin/1.0.163/libexec/lib/node_modules/joplin/main.js'
  ]
}
Error: joplin: failed
Failed executing:
/usr/local/Homebrew/Library/Homebrew/formula.rb:1987:in `block in system'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1925:in `open'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1925:in `system'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/joplin.rb:27:in `block in <class:Joplin>'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1795:in `block (3 levels) in run_test'
/usr/local/Homebrew/Library/Homebrew/utils.rb:474:in `with_env'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1794:in `block (2 levels) in run_test'
/usr/local/Homebrew/Library/Homebrew/formula.rb:867:in `with_logging'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1793:in `block in run_test'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2037:in `block in mktemp'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:57:in `block in run'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:57:in `chdir'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:57:in `run'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2036:in `mktemp'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1787:in `run_test'
/usr/local/Homebrew/Library/Homebrew/test.rb:35:in `block in <main>'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:93:in `block in timeout'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `block in catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:108:in `timeout'
/usr/local/Homebrew/Library/Homebrew/test.rb:34:in `<main>'

billinghamj · 2020-04-23T17:38:08Z

What is typically the approach to this kind of situation? Do we just have to file issues with the other projects and wait until they've resolved downstream before the new Node can be made available?

bayandin · 2020-04-23T18:09:01Z

Could you try to bump revisions for bcoin and joplin (I'm not sure, but it looks like they aren't compatible with node update):

brew bump-revision --message="for node" bcoin
brew bump-revision --message="for node" joplin

billinghamj · 2020-04-23T18:32:23Z

Doesn't seem to help - I'm pretty sure the projects just aren't compatible yet. Maybe they could be attached to the last LTS instead - node@12?

SMillerDev · 2020-04-23T18:37:49Z

Can you file an issue and change them to node@12?

billinghamj · 2020-04-23T18:39:02Z

Sorry actually I think I'm mistaken. Don't really understand why it makes a difference, but bumping the revisions seemingly has fixed it :)

(at least when running the upgrade & test locally)

Bo98 · 2020-04-23T19:16:59Z

Cannot find module ... node-v83-darwin-x64 ...

Yeah, that makes sense. Node 13 was v79. Revision bump is the right thing to do.

billinghamj · 2020-04-23T20:56:42Z

Looks like it's good to merge :)

BrewTestBot · 2020-04-23T21:51:30Z

@issyl0 has triggered a merge.

issyl0 · 2020-04-23T21:56:31Z

Thanks again, @billinghamj! 👋

issyl0 added the build failure CI fails while building the software label Apr 21, 2020

This comment has been minimized.

Sign in to view

node 14.0.0

d9ef24e

billinghamj force-pushed the node-14.0.0 branch from 1620075 to d9ef24e Compare April 23, 2020 14:59

billinghamj added 2 commits April 23, 2020 19:29

bcoin: revision bump for node

f2a772f

joplin: revision bump for node

177d09f

issyl0 added ready to merge PR can be merged once CI is green and removed build failure CI fails while building the software labels Apr 23, 2020

BrewTestBot closed this in 047e79a Apr 23, 2020

billinghamj deleted the node-14.0.0 branch April 23, 2020 22:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

node 14.0.0 #53494

node 14.0.0 #53494

billinghamj commented Apr 21, 2020

issyl0 commented Apr 21, 2020

billinghamj commented Apr 21, 2020

issyl0 commented Apr 21, 2020

This comment has been minimized.

SMillerDev commented Apr 22, 2020

billinghamj commented Apr 22, 2020 •

edited

Loading

billinghamj commented Apr 23, 2020

billinghamj commented Apr 23, 2020

billinghamj commented Apr 23, 2020

billinghamj commented Apr 23, 2020

billinghamj commented Apr 23, 2020

bayandin commented Apr 23, 2020

billinghamj commented Apr 23, 2020

SMillerDev commented Apr 23, 2020

billinghamj commented Apr 23, 2020 •

edited

Loading

Bo98 commented Apr 23, 2020

billinghamj commented Apr 23, 2020

BrewTestBot commented Apr 23, 2020

issyl0 commented Apr 23, 2020

node 14.0.0 #53494

node 14.0.0 #53494

Conversation

billinghamj commented Apr 21, 2020

issyl0 commented Apr 21, 2020

billinghamj commented Apr 21, 2020

issyl0 commented Apr 21, 2020

This comment has been minimized.

SMillerDev commented Apr 22, 2020

billinghamj commented Apr 22, 2020 • edited Loading

billinghamj commented Apr 23, 2020

billinghamj commented Apr 23, 2020

billinghamj commented Apr 23, 2020

billinghamj commented Apr 23, 2020

billinghamj commented Apr 23, 2020

bayandin commented Apr 23, 2020

billinghamj commented Apr 23, 2020

SMillerDev commented Apr 23, 2020

billinghamj commented Apr 23, 2020 • edited Loading

Bo98 commented Apr 23, 2020

billinghamj commented Apr 23, 2020

BrewTestBot commented Apr 23, 2020

issyl0 commented Apr 23, 2020

billinghamj commented Apr 22, 2020 •

edited

Loading

billinghamj commented Apr 23, 2020 •

edited

Loading