Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeling: stop vendoring boost #53506

Closed
wants to merge 1 commit into from
Closed

freeling: stop vendoring boost #53506

wants to merge 1 commit into from

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Apr 21, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • This was causing problems rather than fixing them. As it was, this had Boost linkage errors if the Boost formula was installed.
  • A significant portion of the formula was effort into building a copy of Boost.
  • Some of the fixes in the main Boost formula were not transferred here.
  • It had horrible Mach-O modification hacks.
  • The original motivation was to avoid options which no longer applies.
  • Fixes a blocker of Icu4c 66.1 #52481.

@Bo98 Bo98 mentioned this pull request Apr 22, 2020
5 tasks
@SMillerDev SMillerDev added the ready to merge PR can be merged once CI is green label Apr 22, 2020
@billinghamj billinghamj mentioned this pull request Apr 22, 2020
@BrewTestBot
Copy link
Member

@SMillerDev has triggered a merge.

@Bo98 Bo98 deleted the freeling branch April 22, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants