Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DeleteOffsets operation #2006

Merged
merged 7 commits into from
Sep 9, 2021

Conversation

faillefer
Copy link
Contributor

@faillefer faillefer commented Sep 6, 2021

Implement #1912
Add support for KIP-496: Administrative API to delete consumer offsets:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-496%3A+Administrative+API+to+delete+consumer+offsets

@ghost ghost added the cla-needed label Sep 6, 2021
@faillefer
Copy link
Contributor Author

Waiting to sign the CLA
Submitting the form returns this error :

To sign our CLA 1 field needs to be changed
Submission rate limit exceeded. Please try again later

@faillefer faillefer marked this pull request as ready for review September 7, 2021 07:56
@faillefer faillefer requested a review from bai as a code owner September 7, 2021 07:56
@dnwe
Copy link
Collaborator

dnwe commented Sep 8, 2021

@faillefer many thanks for this well structured PR, it is much appreciated! I've looked over the changes and they seem good to me, I've triggered the CI run and will double check the implementation against the protocol definitions, but I think it will be good to merge after that.

Please could you have another go at completing the CLA signing process today? Perhaps the service was under load when you last attempted.

@faillefer
Copy link
Contributor Author

faillefer commented Sep 8, 2021

Thanks for your review
Sorry for the fmt issues. They are fixed by the last commit (https://github.com/faillefer/sarama/actions/runs/1213257314)

@faillefer
Copy link
Contributor Author

I have retried to submit the CLA but i still have the same error.
I tried from home / office / phone in the last couple of days and it always return the same error

@faillefer
Copy link
Contributor Author

@dnwe i was able to sign the CLA this morning

@ghost ghost removed the cla-needed label Sep 9, 2021
@bai bai merged commit bd4c972 into IBM:master Sep 9, 2021
@bai
Copy link
Contributor

bai commented Sep 9, 2021

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants