-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1182 | Changed regexp to match standard ngrok urls #1311
Conversation
Is anyone checking PRs for this project ? |
What prevent this from been merged ? It's October so I would like to give my 2 cents to #hacktoberfest |
I'm trying to sign the CLA but I get this error |
Please try again, also test is failing, please fix that as well. |
Tried to sign the CLA but I still get the very same error. I've fixed the test and rebased on latest |
@hpatoio Hmm, that's weird. According to this ticket IBM/sarama#2006, someone had the same problem before, and it was resolved after several tries. Could you please also try again? |
I tried 20something times in a 3 hours period. Same error. I've also asked a friend of mine and he got the very same message. |
@hpatoio Sorry for the inconvenience 😭, let me ask around after the holiday to see if I can find a solution for CLA. |
It worked ! I was able to sign the CLA. Can you re run the pipeline ? |
What this PR does
I've changed the regexp used to whitelist requests. By default ngrok urls contains
-
but the regexp used at the moment only allows letters and numbers.With this change requests to URLs like https://cee0-212-222-187-147.ngrok.io work
This issue was reported in #1182