feat: support identify user by id #1115

abdelhamid-f-nasser · 2024-01-29T13:53:12Z

Description of the change

Support the new API which allows identifying user with ID.

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13746

Checklists

Check that the uuid is modified with the value passed to the id parameter when intercepting the request.

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests

Code review

This pull request has a descriptive title and information useful to a reviewer
Issue from task tracker has a link to this pull request

Deprecate the identifyUser method which doesn't accept the ID argument.

mnoseir · 2024-01-29T14:43:39Z

Coverage Report

Label	Coverage	Status
JavaScript	96.2%	✅
Android	49.2%	✅
iOS	40.7%	✅

Generated by 🚫 dangerJS against 84ae7d6

CHANGELOG.md

examples/default/ios/InstabugTests/InstabugSampleTests.m

ios/RNInstabug/InstabugReactBridge.m

a7medev

Good job @abdelhamid-f-nasser! Please check the comments added and we should be good to go 🙏🏼

src/modules/Instabug.ts

android/src/test/java/com/instabug/reactlibrary/RNInstabugReactnativeModuleTest.java

abdelhamid-f-nasser · 2024-01-30T10:13:50Z

@a7medev Thanks for the thorough review 🙏 Please recheck and let me know if anything is amiss.

ahmedAlaaInstabug · 2024-02-05T15:01:35Z

src/modules/Instabug.ts

@@ -227,7 +228,7 @@ export const logUserEvent = (name: string) => {

 /**
 * Appends a log message to Instabug internal log.
- * These logs are then sent along the next uploaded report.
+ * These logs are then sent aalong the next uploaded report.


just a typo mistake

Nice catch @ahmedAlaaInstabug , thanks 🙏

ios/RNInstabug/InstabugReactBridge.h

Support the identifyUser method which accepts the ID of the user.

Remove redundant `identifyUserWithId` method

1. Reorder the parameters passed to identifyUser (was disarranged) 2. Adjust tests to follow naming conventions and use mocks.verify

1. Remove redundant `identifyUserWithId` Api 2. Adjust docs to follow JSDocs conventions for `identifyUser` API.

Rename id to userID

email was passed in place of the userName

Update changelog to match flutter entry

rename identifyUser `id` to `userId`

Jira ID: MOB-13746

* feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]>

* feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <[email protected]> * feat: add more crash scenarios to example app (#1131) * feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]> * feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <[email protected]> * fix:lint issue * fix: CHANGELOG typo issue Co-authored-by: Abdelhamid Nasser <[email protected]> --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]>

Jira ID: MOB-13746

* feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]>

* feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <[email protected]> * feat: add more crash scenarios to example app (#1131) * feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]> * feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <[email protected]> * fix:lint issue * fix: CHANGELOG typo issue Co-authored-by: Abdelhamid Nasser <[email protected]> --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]>

* feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]>

* feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <[email protected]> * feat: add more crash scenarios to example app (#1131) * feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]> * feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <[email protected]> * fix:lint issue * fix: CHANGELOG typo issue Co-authored-by: Abdelhamid Nasser <[email protected]> --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]>

* feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]>

* feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <[email protected]> * feat: add more crash scenarios to example app (#1131) * feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]> * feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <[email protected]> * fix:lint issue * fix: CHANGELOG typo issue Co-authored-by: Abdelhamid Nasser <[email protected]> --------- Co-authored-by: Abdelhamid Nasser <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: AbdElHamid Nasser <[email protected]>

chore(android): deprecate identifyUser

fdb5225

Deprecate the identifyUser method which doesn't accept the ID argument.

abdelhamid-f-nasser force-pushed the feat/support-identify-user-by-id branch from 69f517e to def8189 Compare January 29, 2024 14:20

abdelhamid-f-nasser requested review from a7medev and ahmedAlaaInstabug January 29, 2024 14:22

abdelhamid-f-nasser force-pushed the feat/support-identify-user-by-id branch from def8189 to 845dffe Compare January 29, 2024 14:32

a7medev reviewed Jan 29, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

examples/default/ios/InstabugTests/InstabugSampleTests.m Outdated Show resolved Hide resolved

ios/RNInstabug/InstabugReactBridge.m Outdated Show resolved Hide resolved

a7medev requested changes Jan 29, 2024

View reviewed changes

src/modules/Instabug.ts Outdated Show resolved Hide resolved

android/src/test/java/com/instabug/reactlibrary/RNInstabugReactnativeModuleTest.java Outdated Show resolved Hide resolved

abdelhamid-f-nasser requested a review from a7medev January 30, 2024 10:13

ahmedAlaaInstabug reviewed Feb 5, 2024

View reviewed changes

a7medev requested changes Feb 5, 2024

View reviewed changes

ios/RNInstabug/InstabugReactBridge.h Outdated Show resolved Hide resolved

abdelhamid-f-nasser added 11 commits February 5, 2024 17:05

feat: support IdentifyUserWithId

da725b2

Support the identifyUser method which accepts the ID of the user.

docs: update changelog.md

3cb3eeb

docs: update changelog.md

ecdbfca

chore(ios): resolve review comments

25876b9

Remove redundant `identifyUserWithId` method

chore(android): resolve review comments

e29c20f

1. Reorder the parameters passed to identifyUser (was disarranged) 2. Adjust tests to follow naming conventions and use mocks.verify

chore: resolve review comments

9df0dba

1. Remove redundant `identifyUserWithId` Api 2. Adjust docs to follow JSDocs conventions for `identifyUser` API.

chore(ios): resolve review comments

72907a3

Rename id to userID

test: remove redundant identifyUserWithId mock

86e45e4

test: re-arrange identifyUser arguments

d7ece8f

email was passed in place of the userName

docs: update changelog.md

c42b5bc

Update changelog to match flutter entry

refactor(ios): update identifyUser id param

84ae7d6

rename identifyUser `id` to `userId`

abdelhamid-f-nasser force-pushed the feat/support-identify-user-by-id branch from db9e077 to 84ae7d6 Compare February 5, 2024 15:08

abdelhamid-f-nasser requested review from a7medev and ahmedAlaaInstabug February 5, 2024 15:08

a7medev approved these changes Feb 5, 2024

View reviewed changes

abdelhamid-f-nasser merged commit 3123fe9 into dev Feb 5, 2024
9 of 10 checks passed

abdelhamid-f-nasser deleted the feat/support-identify-user-by-id branch February 5, 2024 15:47

abdelhamid-f-nasser restored the feat/support-identify-user-by-id branch February 5, 2024 15:48

HeshamMegid pushed a commit that referenced this pull request Feb 10, 2024

feat: support identify user by id (#1115)

f165b5c

Jira ID: MOB-13746

ahmedAlaaInstabug pushed a commit that referenced this pull request Feb 20, 2024

feat: support identify user by id (#1115)

763f0e5

Jira ID: MOB-13746

abdelhamid-f-nasser self-assigned this Feb 20, 2024

abdelhamid-f-nasser mentioned this pull request Feb 28, 2024

feat: add runtime code push version API (#1143) #1158

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support identify user by id #1115

feat: support identify user by id #1115

abdelhamid-f-nasser commented Jan 29, 2024 •

edited

Loading

mnoseir commented Jan 29, 2024 •

edited

Loading

a7medev left a comment

abdelhamid-f-nasser commented Jan 30, 2024

ahmedAlaaInstabug Feb 5, 2024

abdelhamid-f-nasser Feb 5, 2024

feat: support identify user by id #1115

feat: support identify user by id #1115

Conversation

abdelhamid-f-nasser commented Jan 29, 2024 • edited Loading

Description of the change

Type of change

Related issues

Checklists

Development

Code review

mnoseir commented Jan 29, 2024 • edited Loading

Coverage Report

a7medev left a comment

Choose a reason for hiding this comment

abdelhamid-f-nasser commented Jan 30, 2024

ahmedAlaaInstabug Feb 5, 2024

Choose a reason for hiding this comment

abdelhamid-f-nasser Feb 5, 2024

Choose a reason for hiding this comment

abdelhamid-f-nasser commented Jan 29, 2024 •

edited

Loading

mnoseir commented Jan 29, 2024 •

edited

Loading