Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add setNDKCrashesEnabled API #1132

Merged
merged 18 commits into from
Feb 19, 2024
Merged

feat: add setNDKCrashesEnabled API #1132

merged 18 commits into from
Feb 19, 2024

Conversation

ahmedAlaaInstabug
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug commented Feb 11, 2024 •
edited
Loading

Description of the change

  1. Map setNDKCrashesEnabled in Javascript side

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID:MOB-13774

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Feb 11, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title feat/add-mapping-to-enable-ndk-crash feat: add setNDKCrashesEnabled API Feb 11, 2024
@mnoseir
Copy link

mnoseir commented Feb 13, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.3% ✅
Android 47.5% ✅
iOS 41.3% ✅

Generated by 🚫 dangerJS against d597ab9

abdelhamid-f-nasser
abdelhamid-f-nasser suggested changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort @ahmedAlaaInstabug !! Please check my suggestions and please add a new changelog entry for this PR. 🙏

a7medev
a7medev requested changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏼, please check the comment I added. Let's also add a changelog entry as Abdelhamid suggested 🙏🏼.

src/modules/CrashReporting.ts Outdated Show resolved Hide resolved
Base automatically changed from dev to master February 15, 2024 12:31
@ahmedAlaaInstabug ahmedAlaaInstabug changed the base branch from master to dev February 15, 2024 12:56
abdelhamid-f-nasser
abdelhamid-f-nasser reviewed Feb 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ahmedAlaaInstabug and others added 11 commits February 18, 2024 14:47
@ahmedAlaaInstabug @abdelhamid-f-nasser
Update CHANGELOG.md
ea0e619 
Co-authored-by: Abdelhamid Nasser <[email protected]>
@ahmedAlaaInstabug @abdelhamid-f-nasser @a7medev
feat: add more crash scenarios to example app (#1131)
3ab63ab 
* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <[email protected]>
Co-authored-by: Ahmed Mahmoud <[email protected]>
Co-authored-by: AbdElHamid Nasser <[email protected]>
@ahmedAlaaInstabug
feat_add_setNDKCrashesEnabled
5152730
@ahmedAlaaInstabug
fix android_testing issue
e9b7824
@ahmedAlaaInstabug
rename_test_cases
a7690a5
@ahmedAlaaInstabug
fix_pr_comments
666e4da
@ahmedAlaaInstabug
feat/add-ndk-demo-crash-buttons
f0a87ad
@ahmedAlaaInstabug
chore: add ChangeLog changes
b5df83d
@ahmedAlaaInstabug @abdelhamid-f-nasser
Update CHANGELOG.md
0aecc38 
Co-authored-by: Abdelhamid Nasser <[email protected]>
@ahmedAlaaInstabug
Merge remote-tracking branch 'origin/feat/add-mapping-to-enable-ndk-c…
e168198 
…rash' into feat/add-mapping-to-enable-ndk-crash

# Conflicts:
#	CHANGELOG.md
@ahmedAlaaInstabug
fix:lint issue
1b9d01e
abdelhamid-f-nasser
abdelhamid-f-nasser reviewed Feb 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ahmedAlaaInstabug @abdelhamid-f-nasser
fix: CHANGELOG typo issue
d597ab9 
Co-authored-by: Abdelhamid Nasser <[email protected]>
@ahmedAlaaInstabug ahmedAlaaInstabug merged commit 3fae0be into dev Feb 19, 2024
9 of 11 checks passed
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the feat/add-mapping-to-enable-ndk-crash branch February 19, 2024 12:28
ahmedAlaaInstabug added a commit that referenced this pull request Feb 20, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser @a7medev
feat: add setNDKCrashesEnabled API (#1132)
9b86a46 
* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <[email protected]>

* feat: add more crash scenarios to example app (#1131)

* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <[email protected]>
Co-authored-by: Ahmed Mahmoud <[email protected]>
Co-authored-by: AbdElHamid Nasser <[email protected]>

* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <[email protected]>

* fix:lint issue

* fix:  CHANGELOG typo issue

Co-authored-by: Abdelhamid Nasser <[email protected]>

---------

Co-authored-by: Abdelhamid Nasser <[email protected]>
Co-authored-by: Ahmed Mahmoud <[email protected]>
Co-authored-by: AbdElHamid Nasser <[email protected]>
abdelhamid-f-nasser added a commit that referenced this pull request Feb 28, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser @a7medev
feat: add setNDKCrashesEnabled API (#1132)
67b5590 
* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <[email protected]>

* feat: add more crash scenarios to example app (#1131)

* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <[email protected]>
Co-authored-by: Ahmed Mahmoud <[email protected]>
Co-authored-by: AbdElHamid Nasser <[email protected]>

* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <[email protected]>

* fix:lint issue

* fix:  CHANGELOG typo issue

Co-authored-by: Abdelhamid Nasser <[email protected]>

---------

Co-authored-by: Abdelhamid Nasser <[email protected]>
Co-authored-by: Ahmed Mahmoud <[email protected]>
Co-authored-by: AbdElHamid Nasser <[email protected]>
abdelhamid-f-nasser added a commit that referenced this pull request Feb 28, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser @a7medev
feat: add setNDKCrashesEnabled API (#1132)
289b416 
* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <[email protected]>

* feat: add more crash scenarios to example app (#1131)

* feat(example): add nested complex views (#1111)

Jira ID: MOB-13737

* fix hybrid mode code push version init (#1108)

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* ci: migrate macos machines to m1 (#1114)

* feat: support identify user by id (#1115)

Jira ID: MOB-13746

* ci: replace  d11 cluster url in UploadSourcemaps (#1122)

* fix(android): resolve private views through UI manager directly (#1121)

* feat: support switching to native network interception (#1120)

* feat(example): Add more sdk crashes buttons

* chore(android): ignore jetbrains ide run configurations (#1110)

Jira ID: MOB-13736

* feat(example): Add more sdk crashes buttons

* fix dev merge issue

* feat_add_crash_buttons

* feat_add_crash_buttons

* feat_add_crash_buttons

* fix: PlatformListTile typo  name

---------

Co-authored-by: Abdelhamid Nasser <[email protected]>
Co-authored-by: Ahmed Mahmoud <[email protected]>
Co-authored-by: AbdElHamid Nasser <[email protected]>

* feat_add_setNDKCrashesEnabled

* fix android_testing issue

* rename_test_cases

* fix_pr_comments

* feat/add-ndk-demo-crash-buttons

* chore: add ChangeLog changes

* Update CHANGELOG.md

Co-authored-by: Abdelhamid Nasser <[email protected]>

* fix:lint issue

* fix:  CHANGELOG typo issue

Co-authored-by: Abdelhamid Nasser <[email protected]>

---------

Co-authored-by: Abdelhamid Nasser <[email protected]>
Co-authored-by: Ahmed Mahmoud <[email protected]>
Co-authored-by: AbdElHamid Nasser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev requested changes

@abdelhamid-f-nasser abdelhamid-f-nasser abdelhamid-f-nasser approved these changes

Assignees

@ahmedAlaaInstabug ahmedAlaaInstabug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedAlaaInstabug @mnoseir @abdelhamid-f-nasser @a7medev