Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected behavior for DPCTL_ENABLE_L0_PROGRAM_CREATION=OFF #1039

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Corrected behavior for DPCTL_ENABLE_L0_PROGRAM_CREATION=OFF #1039

merged 1 commit into from
Jan 22, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Corrected behavior for -DDPCTL_ENABLE_L0_PROGRAM_CREATION=OFF

Shortened preprocessor variable name from
DPCTL_ENABLE_L0_PROGRAM_CREATION to DPCTL_ENABLE_L0_PROGRAM.

Placed additional uses of L0-specific functions it preprocessor conditioned sections.

  • Have you provided a meaningful PR description?
  • Have you tested your changes locally for CPU and GPU devices?

Tested with both python scripts/build_locally.py and python scripts/build_locally.py --no-level-zero.

@oleksandr-pavlyk
Correct behavior for DPCTL_ENABLE_L0_PROGRAM_CREATION=OFF
f404998 
Shortened preprocessor variable name from
DPCTL_ENABLE_L0_PROGRAM_CREATION to DPCTL_ENABLE_L0_PROGRAM

Placed additional uses of L0-specific functions it preprocessor
conditioned sections.
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1039/index.html

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: ?%. Remained the same when pulling f404998 on correct-preprocessor-exclusion-logic into 83ad22d on master.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 84.102% (+1.9%) from 82.23% when pulling f404998 on correct-preprocessor-exclusion-logic into 83ad22d on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_22 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 7071b35 into master Jan 22, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the correct-preprocessor-exclusion-logic branch January 22, 2023 17:52
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_24 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

oleksandr-pavlyk added a commit that referenced this pull request Jan 22, 2023
@oleksandr-pavlyk
Fix loss of L0-program creation from gh-1039
87b7545 
Changes from gh-1039 inadvertently broke L0 program creation
support, resulting in failure of test

test_sycl_program.py::test_create_program_from_spirv_l0

This PR fixes it, while still resolving issues raised in gh-1039.
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Jan 22, 2023
Merged
3 tasks
oleksandr-pavlyk added a commit that referenced this pull request Jan 22, 2023
@oleksandr-pavlyk
Merge pull request #1041 from IntelPython/hot-fix-fallout-from-gh-1039
1916370 
Fix loss of L0-program creation from gh-1039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @coveralls