Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loss of L0-program creation from gh-1039 #1041

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Changes from gh-1039 inadvertently broke L0 program creation support, resulting in failure of test

test_sycl_program.py::test_create_program_from_spirv_l0

This PR fixes it, while still resolving issues raised in gh-1039.

  • Have you provided a meaningful PR description?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

Changes from gh-1039 inadvertently broke L0 program creation
support, resulting in failure of test

test_sycl_program.py::test_create_program_from_spirv_l0

This PR fixes it, while still resolving issues raised in gh-1039.
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 82.19% (-1.9%) from 84.102% when pulling 87b7545 on hot-fix-fallout-from-gh-1039 into 7071b35 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_26 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 1916370 into master Jan 22, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the hot-fix-fallout-from-gh-1039 branch January 22, 2023 19:49
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_26 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants