Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usm_ndarray repr, str exposed in dpctl.tensor #1060

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

ndgrigorian
Copy link
Collaborator

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Exposed usm_ndarray_repr and usm_ndarray_str in dpctl.tensor.
This allows extensions and subclasses to leverage usm_ndarray_repr for printing with custom prefixes/class names, formatting, etc.
Unblocks IntelPython/dpnp#1279

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_60 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_60 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk
Copy link
Collaborator

Thank you @ndgrigorian ! This looks good. Please allow few hours to @vtavana to provide feedback.

@ndgrigorian ndgrigorian merged commit d77f570 into master Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@ndgrigorian ndgrigorian deleted the print-expose-repr branch February 3, 2023 20:09
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_75 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants