Print dpnp array #1279
Merged
Print dpnp array #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
reviewed
Jan 27, 2023
antonwolfy
reviewed
Jan 27, 2023
oleksandr-pavlyk
requested changes
Jan 30, 2023
vtavana
force-pushed
the
print_dpnp_array
branch
2 times, most recently
from
5040914 to
d74d96a
Compare
5 tasks
antonwolfy
reviewed
Feb 3, 2023
| result = str(dpnp.array([[1, 2], [3, 4]])) | ||
| expected = "[[1 2]\n [3 4]]" | ||
| assert(result==expected) | ||
|
|
There was a problem hiding this comment.
Probably to add also a test case with ... in the string output.
|
@vtavana Could you please install/build dpctl from sources of IntelPython/dpctl#1060 and change your def __repr__(self):
return dpt.usm_ndarray_repr(self._array_obj, prefix="ndarray")Adjust the @antonwolfy, @samaid, @npolina4 Should we choose |
vtavana
force-pushed
the
print_dpnp_array
branch
from
d74d96a to
67d5cb1
Compare
oleksandr-pavlyk
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding string representation of the array object using
__str__and__repr__