Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/advanced indexing #1095

Merged
merged 61 commits into from
Mar 4, 2023
Merged

Feature/advanced indexing #1095

merged 61 commits into from
Mar 4, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This is a draft PR with advance indexing implementation.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

oleksandr-pavlyk and others added 30 commits February 15, 2023 13:47
@oleksandr-pavlyk
Fixed typo in docstring
831a5cb
@oleksandr-pavlyk
Fixed TODO in utility _zero_like
402c1d6
@oleksandr-pavlyk
Extended _basic_slice_meta to process advanced indexing specs
d7fc400
@oleksandr-pavlyk
Added prototype with mock implementation of extract/place/take/put
bcc305b
@oleksandr-pavlyk
Change mod of _slicing.pxi to be non-executable
a1791e2
@oleksandr-pavlyk
Added ExecutionPlacementError
ea339eb
@oleksandr-pavlyk
Factored out dpt.dtype and dpt.bool, etc. definitions into dedicated …
483a423 
…file
@oleksandr-pavlyk
Deployed lazy implementation of advanced indexing to develop tests
efcd9cb
@oleksandr-pavlyk
Ensure that rhs can be a scalar or numpy array
04e4b51
@oleksandr-pavlyk
Added new test file to test indexing
6589dfa
@oleksandr-pavlyk
Added _constants, and extended advanced indexing tests
d66c494
@oleksandr-pavlyk
More tests for advanced indexing
61917a5
@oleksandr-pavlyk
Removed proto/ folder
c2d7928
@ndgrigorian
Implemented advanced indexing kernels
832a981 
- Kernels for _take, _put
- Python API functions for take, put
@oleksandr-pavlyk
Merge remote-tracking branch 'origin/master' into feature/advanced-in…
e0ae1ff 
…dexing
@ndgrigorian
Changes to advanced indexing
6239eb7 
- Clipping now clips indices to -n <= i < n for n = axis size
- Fixed a segfault caused by a typo when copying strides
@ndgrigorian
Changes to advanced_indexing.cpp
a0895be 
- Moved indices validation to avoid memory leaks
- Refactored for loop over orthogonal elements of shapes
- Direct initialization of sycl::event vectors
@ndgrigorian
Fixed missing cast for indices clip/wrap
728b8e6
@oleksandr-pavlyk
Fixed error from dpt.flip(dpt.arange(5))[dpt.arange(2)]
333f9e6
@oleksandr-pavlyk
More tests for advanced indexing
ab79d84
@oleksandr-pavlyk
Fixed error from dpt.flip(dpt.arange(5))[dpt.arange(2)]
a966830
@oleksandr-pavlyk
More tests for advanced indexing
8523d8e
@oleksandr-pavlyk
Adding basic take, and basic put tests
81ba473
@oleksandr-pavlyk
Merge branch 'feature/advanced-indexing' into take-put-impl
1f61206
@oleksandr-pavlyk
Turn debugging on for test_windows test run
7c0c6f0
@ndgrigorian
Added several array indexing tests
156f7f0 
- Tests include
- strided data for take and put
- strided indices for take and put
- indexing compute follows data
- indexing argument validation
@ndgrigorian
Put calls in tests corrected, organized put logic
d42b019
@ndgrigorian
Test fixes
877c3c7 
- Error for non-integer usm_ndarrays used as indices changed to IndexError
@ndgrigorian
Moved advanced_indexing pointer range validation
e296d87
@ndgrigorian
Fixed typo in advanced_indexing kernels
0cf7ba4
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1095/index.html

@coveralls
Copy link
Collaborator

coveralls commented Mar 2, 2023 •
edited
Loading

Coverage Status

Coverage: 82.363% (+0.05%) from 82.316% when pulling 13c5db7 on feature/advanced-indexing into bc78431 on master.

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_112 ran successfully.
Passed: 35
Failed: 799
Skipped: 280

oleksandr-pavlyk and others added 7 commits March 2, 2023 19:35
@oleksandr-pavlyk
Implements place, extract, nonzero kernels, and Python API for them
2446b00 
Implemented mask_positions, _extract, _place, _nonzero and _array_overlap
APIs.
@oleksandr-pavlyk
Added missing include
c1f0081
@oleksandr-pavlyk
Hooked up boolean indexing, first attempt
849a3ea
@oleksandr-pavlyk
Changes per clang-format 11
ed279d6
@oleksandr-pavlyk
Used Strided1DCyclingIndexer in place implementations
3ced89a 
This allows to implement behavior of place which cycles over
values of val array if that is shorter than the number of non-zero
elements in the mask.
@oleksandr-pavlyk
Implemented dpctl.tensor.place as per documented behavior.
19691ca
@ndgrigorian
_take and _put returned event changes
03c4822 
- Host_tasks now collected and used as dependencies for dec_ref of py arguments
- Return temporaries deallocation event to further prevent dangling host_tasks
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_113 ran successfully.
Passed: 35
Failed: 799
Skipped: 280

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_122 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_123 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

ndgrigorian and others added 2 commits March 3, 2023 17:21
@ndgrigorian
dpt.take and dpt.put changes
0a7ea0c 
- Improved conformity to array API standard
- Added docstrings
@oleksandr-pavlyk
Fixed rst in docstrings of extract/place
13c5db7
@oleksandr-pavlyk oleksandr-pavlyk merged commit 1ac92d8 into master Mar 4, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the feature/advanced-indexing branch March 4, 2023 05:23
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_124 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_125 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_125 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian