Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an empty value check for dpt.place #1105

Merged

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR adds a check for an empty array for vals argument and throws a ValueError exception in case of truth as numpy and covers this case with test.

The PR solves #1104.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 82.385% (+0.006%) from 82.378% when pulling 66c56a4 on vlad-perevezentsev:fix_dpt_place into 6dc5479 on IntelPython:master.

Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vlad-perevezentsev

@oleksandr-pavlyk oleksandr-pavlyk merged commit 78875e9 into IntelPython:master Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_2 ran successfully.
Passed: 36
Failed: 798
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants