Update empty vals check in dpt.place #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpctl/tensor/_indexing_functions.py
Outdated
| @@ -293,7 +293,7 @@ def place(arr, mask, vals): | |||
| raise dpctl.utils.ExecutionPlacementError | |||
| if arr.shape != mask.shape or vals.ndim != 1: | |||
| raise ValueError("Array sizes are not as required") | |||
| if vals.size == 0: | |||
| if vals.size == 0 and dpt.nonzero(mask)[0].size: | |||
There was a problem hiding this comment.
The number of set elements in the mask is computed on line 299 and assigned to variable nz_count.
Perhaps it is cleaner to move the check for vals.size == 0 till after nz_count value is known?
There was a problem hiding this comment.
Yes, It looks cleaner.
Done!
oleksandr-pavlyk
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
LGTM! Thank you for catching the issue and providing the fix @vlad-perevezentsev
|
Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_5 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements #1105 .
The original behavior of
numpy.placethrows an exception when it gets an empty array ofvalsargumentBUT if the
maskargument contains allFalse,numpy.placeworks without exceptions (example).