Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements log2 and log10 #1267

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Conversation

ndgrigorian
Copy link
Collaborator

This PR implements elementwise functions dpctl.tensor.log2, dpctl.tensor.log10, and dpctl.tensor.logaddexp.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian force-pushed the elementwise-functions-log-variants branch from 9842cdd to 19663c9 Compare June 29, 2023 08:45
@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Jun 29, 2023

Coverage Status

coverage: 83.287% (+0.005%) from 83.282% when pulling c90e5d5 on elementwise-functions-log-variants into 7510d7e on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_5 ran successfully.
Passed: 410
Failed: 590
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_5 ran successfully.
Passed: 408
Failed: 592
Skipped: 119

@ndgrigorian ndgrigorian changed the title Implements log2, log10, and logaddexp Implements log2 and log10 Jul 4, 2023
@ndgrigorian ndgrigorian force-pushed the elementwise-functions-log-variants branch from 19663c9 to d59f6c0 Compare July 4, 2023 09:41
@ndgrigorian ndgrigorian marked this pull request as ready for review July 4, 2023 10:02
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_9 ran successfully.
Passed: 415
Failed: 585
Skipped: 119

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_10 ran successfully.
Passed: 414
Failed: 586
Skipped: 119

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thanks @ndgrigorian

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_16 ran successfully.
Passed: 448
Failed: 552
Skipped: 119

@ndgrigorian ndgrigorian merged commit bc59de9 into master Jul 4, 2023
@ndgrigorian ndgrigorian deleted the elementwise-functions-log-variants branch July 4, 2023 18:30
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_13 ran successfully.
Passed: 449
Failed: 551
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants