-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with numpy 2.0 #1760
Build with numpy 2.0 #1760
Conversation
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_166 ran successfully. |
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_167 ran successfully. |
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_173 ran successfully. |
e492282
to
b16ac8d
Compare
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_173 ran successfully. |
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_177 ran successfully. |
In order for this PR to be built in the internal CI with 2.0, I need to change the mamba build flag to |
For some reason, the environment still resolved in favor of 1.26.4, even despite |
@ekomarova This PR modified The test environment continues to use Intel channel and thus 3.9, 3.10, and 3.11 install numpy 1.26.4 into test environment from there, while for Python 3.12 the latest numpy gets installed from conda-forge channel. |
@oleksandr-pavlyk
In the current situation, conda can only solve the environment so that it satisfies the first two conditions. Since numpy 1.26 is available on |
It looks like in order to make this work in internal CI, we need to rebuild numpy from conda-forge with 2025 mkl, otherwise we will get conflicts. We can plan this activity. |
Just for information: building numpy 2.0 with conda-forge recipe with 2025 mkl is WIP |
Update: We expect a built numpy 2.0 package in the next few days |
We managed to fix the windows problem. Next, I plan to test this PR with built numpy 2.0, and then add the status |
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_280 ran successfully. |
The package is hosted on a separate channel https://af01p-igk.devtools.intel.com/ui/repos/tree/General/idp-conda-pkgserver-igk-local/numpy, but I can't test this PR yet due to channel problems. As soon as we fix them, I'll restart the checks |
5107bbb
to
07befb6
Compare
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_285 ran successfully. |
We need to fix something in CI logic in order for the conda build to pass, but in general this PR is now being built with numpy 2.0.1, and tested with 1.26.4 in internal CI |
Test examples with Python 3.11
07befb6
to
318d55c
Compare
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_308 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think we can merge this.
Build conda packages with NumPy 2.0 in the build environment. The
meta.yaml
file fordpctl
was changed to not usepin_compatible('numpy', min='x.x', max='x')
per migration guidelines from conda-forge.Testing should still pick NumPy 1.26.4 from Intel channel.