Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove numpy pinning from conda receipt #1771

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Remove numpy pinning from conda receipt #1771

merged 1 commit into from
Apr 2, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 2, 2024 •
edited
Loading

The PR propose to remove pinning of numpy version from conda receipt, because it affects flow of internal CI where the numpy version is specified by conda command.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Apr 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review April 2, 2024 21:44
vtavana
vtavana approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit d380776 into master Apr 2, 2024
45 checks passed
@antonwolfy antonwolfy deleted the unpin-max-numpy branch April 2, 2024 21:55
github-actions bot added a commit that referenced this pull request Apr 2, 2024
@github-actions
Removed numpy pinning from conda receipt (#1771) d380776
168cf01
@ekomarova ekomarova mentioned this pull request Jul 29, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana