Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependent events to async call #1249

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Add dependent events to async call #1249

merged 3 commits into from
Dec 18, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

Add dependant event support for async kernel submission. To simplify these changes Kernel Launcher was updated to remove array allocation duplicates.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Dec 15, 2023
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd as a code owner December 15, 2023 21:58
@ZzEeKkAa ZzEeKkAa force-pushed the feature/dependant_events branch 4 times, most recently from b843d70 to 2714471 Compare December 15, 2023 23:53
@ZzEeKkAa ZzEeKkAa changed the title Feature/dependant events Add dependent events to async call Dec 16, 2023
@diptorupd
Copy link
Contributor

diptorupd commented Dec 17, 2023 •
edited
Loading

2714471 is not needed. I have handled the needed changes to support Numba 0.59 in #1250

@ZzEeKkAa ZzEeKkAa force-pushed the feature/dependant_events branch from 2714471 to 7703353 Compare December 18, 2023 15:54
@ZzEeKkAa ZzEeKkAa force-pushed the feature/dependant_events branch from 7703353 to 34bc454 Compare December 18, 2023 18:58
@ZzEeKkAa ZzEeKkAa force-pushed the feature/dependant_events branch from 34bc454 to 3cfa80b Compare December 18, 2023 19:06
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd December 18, 2023 19:06
diptorupd
diptorupd approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Finally we have this feature 👍

@diptorupd diptorupd merged commit 6b76fd3 into main Dec 18, 2023
30 checks passed
@diptorupd diptorupd deleted the feature/dependant_events branch December 18, 2023 19:49
github-actions bot added a commit that referenced this pull request Dec 18, 2023
@github-actions
Merge pull request #1249 from IntelPython/feature/dependant_events
6cc9577 
Add dependent events to async call 6b76fd3
This was referenced Dec 18, 2023
Closed
Closed
Closed
github-actions bot added a commit to chudur-budur/numba-dpex that referenced this pull request Dec 18, 2023
@github-actions
Merge pull request IntelPython#1249 from IntelPython/feature/dependan…
9ca7ff8 
…t_events

Add dependent events to async call 6b76fd3
@diptorupd diptorupd mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd