Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to KernelDispatcher to support numba 0.59 #1250

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

diptorupd
Copy link
Contributor

  • Have you provided a meaningful PR description?

The impl_kind class attribute was removed from numba's Dispatcher class in 0.59.0rc1. The _compiler attribute for Dispatcher is now always set to numba's _FunctionCompiler class.

To accommodate for these changes, numba_dpex.experimental.dispatcher.KernelDispatcher will conditionally set its _compiler attribute to the _KernelCompiler class when numba version in use is >0.59, otherwise will default to old behaviour.

  • [] Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd requested a review from ZzEeKkAa December 17, 2023 00:20
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ZzEeKkAa ZzEeKkAa merged commit 72d8a32 into main Dec 18, 2023
38 of 44 checks passed
@ZzEeKkAa ZzEeKkAa deleted the support_numba_0.59 branch December 18, 2023 15:52
github-actions bot added a commit that referenced this pull request Dec 18, 2023
Changes to KernelDispatcher to support numba 0.59 72d8a32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants