Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of sub-group barrier operation #1300

Closed
wants to merge 2 commits into from

Conversation

adarshyoga
Copy link
Contributor

@adarshyoga adarshyoga commented Jan 30, 2024

  • Have you provided a meaningful PR description?

This PR contains implementation of sub_group_barrier function that synchronizes across all work-items in a sub-group. It currently lacks a test case to verify the functionality of the barrier call. The tests need to be implemented once sub-group feature is added.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@adarshyoga adarshyoga requested a review from diptorupd January 30, 2024 07:26
@adarshyoga adarshyoga self-assigned this Jan 30, 2024
@adarshyoga adarshyoga marked this pull request as draft January 30, 2024 17:49
@adarshyoga adarshyoga force-pushed the experimental/barrier_ols branch from 01ad320 to e10a49e Compare January 30, 2024 23:02
@ZzEeKkAa ZzEeKkAa force-pushed the experimental/barrier_ols branch 3 times, most recently from 8ca9551 to 769d960 Compare February 3, 2024 00:40
Base automatically changed from experimental/barrier_ols to main February 3, 2024 01:12
@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Feb 3, 2024

After #1310 is merged we have to follow sycl syntax and make it work using group_barrier(nd_item.get_sub_group(), MemoryScope.DEVICE)

@adarshyoga
Copy link
Contributor Author

Now that the group_barrier function accepts a reference to a group as argument, we no longer need a separate sub_group_barrier.
A barrier across a sub-group can be achieved by calling group_barrier and passing a reference to a sub-group which will extend group.

@adarshyoga adarshyoga closed this Feb 16, 2024
@diptorupd diptorupd deleted the experimental/sg_barrier_ols branch February 16, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants