Add Group and overload NdItem.get_group() #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZzEeKkAa
force-pushed
the
feature/nd_item_get_group
branch
from
cd9026f to
267ac4f
Compare
ZzEeKkAa
force-pushed
the
feature/nd_item_get_group
branch
from
267ac4f to
5c80b0f
Compare
5 tasks
diptorupd
reviewed
Feb 3, 2024
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_index_space_id_overloads.py
Outdated
Show resolved
Hide resolved
diptorupd
reviewed
Feb 3, 2024
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_index_space_id_overloads.py
Outdated
Show resolved
Hide resolved
ZzEeKkAa
force-pushed
the
feature/nd_item_get_group
branch
2 times, most recently
from
230f170 to
c0f6d2f
Compare
ZzEeKkAa
changed the title
ZzEeKkAa
force-pushed
the
feature/nd_item_get_group
branch
from
c0f6d2f to
17c60e3
Compare
diptorupd
suggested changes
Feb 3, 2024
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_group_barrier_overloads.py
Outdated
Show resolved
Hide resolved
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_index_space_id_overloads.py
Outdated
Show resolved
Hide resolved
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_index_space_id_overloads.py
Outdated
Show resolved
Hide resolved
ZzEeKkAa
force-pushed
the
feature/nd_item_get_group
branch
3 times, most recently
from
e8290d4 to
588a65a
Compare
adarshyoga
reviewed
Feb 5, 2024
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_index_space_id_overloads.py
Show resolved
Hide resolved
adarshyoga
suggested changes
Feb 6, 2024
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_index_space_id_overloads.py
Outdated
Show resolved
Hide resolved
diptorupd
force-pushed
the
feature/nd_item_get_group
branch
from
588a65a to
6101f49
Compare
diptorupd
force-pushed
the
feature/nd_item_get_group
branch
from
6101f49 to
dc6c1b0
Compare
github-actions bot
added a commit
that referenced
this pull request
Feb 6, 2024
Add Group and overload NdItem.get_group() ccb7606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Group class that is mock for the
sycl::group. Adds corresponding numba type with empty struct data model to avoid any allocations, since it is just typing feature. As a result barriers can be used only at NdRanges, which is aligned with sycl.