Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make numba 0.58 the minimum supported version #1307

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

diptorupd
Copy link
Contributor

  • Have you provided a meaningful PR description?

Now that Numba 0.59 is out, we can deprecate support for Numba 0.57 and remove one of the numba monkey patches we have been carrying along for a while. The patch was pushed upstream and is available since 0.58 release.

Update all configs and remove the patch.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd requested a review from ZzEeKkAa February 2, 2024 19:19
@diptorupd diptorupd force-pushed the update/min_required_numba_is_0.58 branch from 2405660 to 1ef0291 Compare February 2, 2024 20:32
@ZzEeKkAa ZzEeKkAa force-pushed the update/min_required_numba_is_0.58 branch from 1ef0291 to da1db14 Compare February 2, 2024 21:10
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZzEeKkAa ZzEeKkAa merged commit b0ea6aa into main Feb 2, 2024
52 of 55 checks passed
@ZzEeKkAa ZzEeKkAa deleted the update/min_required_numba_is_0.58 branch February 2, 2024 22:16
github-actions bot added a commit that referenced this pull request Feb 2, 2024
…s_0.58

Make numba 0.58 the minimum supported version b0ea6aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants